AppImage is missing localization #1382
Assignees
Labels
Projects
Milestone
Comments
crsib
added
bug
|
See also this Forum post: audacity-wxgtk2 3.0.3 do not portuguese language |
|
Workaround (previously posted here: https://forum.audacityteam.org/viewtopic.php?p=431498#p431498). The audacity.cfg file may be manually edited (while Audacity is NOT running) to select the required language. For example, for French: The Audacity 3.0.3 AppImage will then open with the selected language (in this case, French). |
shoogle
added a commit
to shoogle/audacity
that referenced
this issue
Sep 14, 2021
shoogle
added a commit
to shoogle/audacity
that referenced
this issue
Sep 15, 2021
The INSTALL_PREFIX variable in src/audacity_config.h.in was being passed into the program as an empty string. The file is configured in the top-level CMakeLists.txt but INSTALL_PREFIX is defined in src/CMakeLists.txt. CMake variables are not passed to the parent scope unless explicitly requested. Partially fix audacity#1382. Allows Audacity to find the translations when they are at the default location specified by INSTALL_PREFIX, but not if they have been moved elsewhere. This works for distro builds but it's not enough to get the AppImage working again.
shoogle
added a commit
to shoogle/audacity
that referenced
this issue
Sep 15, 2021
Audacity and its resources (e.g. modules, translations, etc.) are installed to fixed locations defined during configuration by the CMake variable INSTALL_PREFIX. Executable: INSTALL_PREFIX/bin/audacity Resources: INSTALL_PREFIX/share/* Typical values: INSTALL_PREFIX: /usr/local Executable: /usr/local/bin/audacity Resources: /usr/local/share/* Previously, at runtime Audacity would check for resources at the location specified by INSTALL_PREFIX. This worked fine as long as the resources were never moved from that location, which is usually true for distribution packages and self-compiled builds. However, if the resources were ever moved from where CMake installed them then Audacity would be unable to find them at runtime. This is a problem for the AppImage, which self-mounts at a different temporary location every time it is run, meaning that the resources are in a different place each time, and never at the place specified in INSTALL_PREFIX. Typical values for the AppImage: INSTALL_PREFIX: /home/runner/work/audacity/audacity/build/install Executable: /tmp/.mount_audaciXXXXXX/usr/bin/audacity Resources: /tmp/.mount_audaciXXXXXX/usr/share/* (Where 'XXXXXX' is a different alphanumeric sequence on each run.) To solve this, a PORTABLE_PREFIX is constructed at runtime by dropping the final two components of the path to the exectuable. Executable: /some/directory/bin/audacity PORTABLE_PREFIX: /some/directory (dropped '/bin/audacity') Resources: /some/directory/share/* This enables Audacity to find the resources even if they are moved, as long as the executable and resources are moved together (i.e. their location relative to each other stays the same), which is the case with the AppImage. As a fallback in case the executable and resources become separated (i.e. their location relative to each other changes) Audacity will revert back to using the fixed location specified by INSTALL_PREFIX. Fix audacity#1382.
Paul-Licameli
moved this from In progress
to Review In Progress
in Sprint 5 - Release 3.1
Paul-Licameli
pushed a commit
that referenced
this issue
Sep 16, 2021
The INSTALL_PREFIX variable in src/audacity_config.h.in was being passed into the program as an empty string. The file is configured in the top-level CMakeLists.txt but INSTALL_PREFIX is defined in src/CMakeLists.txt. CMake variables are not passed to the parent scope unless explicitly requested. Partially fix #1382. Allows Audacity to find the translations when they are at the default location specified by INSTALL_PREFIX, but not if they have been moved elsewhere. This works for distro builds but it's not enough to get the AppImage working again.
Paul-Licameli
pushed a commit
that referenced
this issue
Sep 16, 2021
Audacity and its resources (e.g. modules, translations, etc.) are installed to fixed locations defined during configuration by the CMake variable INSTALL_PREFIX. Executable: INSTALL_PREFIX/bin/audacity Resources: INSTALL_PREFIX/share/* Typical values: INSTALL_PREFIX: /usr/local Executable: /usr/local/bin/audacity Resources: /usr/local/share/* Previously, at runtime Audacity would check for resources at the location specified by INSTALL_PREFIX. This worked fine as long as the resources were never moved from that location, which is usually true for distribution packages and self-compiled builds. However, if the resources were ever moved from where CMake installed them then Audacity would be unable to find them at runtime. This is a problem for the AppImage, which self-mounts at a different temporary location every time it is run, meaning that the resources are in a different place each time, and never at the place specified in INSTALL_PREFIX. Typical values for the AppImage: INSTALL_PREFIX: /home/runner/work/audacity/audacity/build/install Executable: /tmp/.mount_audaciXXXXXX/usr/bin/audacity Resources: /tmp/.mount_audaciXXXXXX/usr/share/* (Where 'XXXXXX' is a different alphanumeric sequence on each run.) To solve this, a PORTABLE_PREFIX is constructed at runtime by dropping the final two components of the path to the exectuable. Executable: /some/directory/bin/audacity PORTABLE_PREFIX: /some/directory (dropped '/bin/audacity') Resources: /some/directory/share/* This enables Audacity to find the resources even if they are moved, as long as the executable and resources are moved together (i.e. their location relative to each other stays the same), which is the case with the AppImage. As a fallback in case the executable and resources become separated (i.e. their location relative to each other changes) Audacity will revert back to using the fixed location specified by INSTALL_PREFIX. Fix #1382.
|
Works fine. |
hugofloresgarcia
pushed a commit
to audacitorch/audacity
that referenced
this issue
Oct 4, 2021
The INSTALL_PREFIX variable in src/audacity_config.h.in was being passed into the program as an empty string. The file is configured in the top-level CMakeLists.txt but INSTALL_PREFIX is defined in src/CMakeLists.txt. CMake variables are not passed to the parent scope unless explicitly requested. Partially fix audacity#1382. Allows Audacity to find the translations when they are at the default location specified by INSTALL_PREFIX, but not if they have been moved elsewhere. This works for distro builds but it's not enough to get the AppImage working again.
hugofloresgarcia
pushed a commit
to audacitorch/audacity
that referenced
this issue
Oct 4, 2021
Audacity and its resources (e.g. modules, translations, etc.) are installed to fixed locations defined during configuration by the CMake variable INSTALL_PREFIX. Executable: INSTALL_PREFIX/bin/audacity Resources: INSTALL_PREFIX/share/* Typical values: INSTALL_PREFIX: /usr/local Executable: /usr/local/bin/audacity Resources: /usr/local/share/* Previously, at runtime Audacity would check for resources at the location specified by INSTALL_PREFIX. This worked fine as long as the resources were never moved from that location, which is usually true for distribution packages and self-compiled builds. However, if the resources were ever moved from where CMake installed them then Audacity would be unable to find them at runtime. This is a problem for the AppImage, which self-mounts at a different temporary location every time it is run, meaning that the resources are in a different place each time, and never at the place specified in INSTALL_PREFIX. Typical values for the AppImage: INSTALL_PREFIX: /home/runner/work/audacity/audacity/build/install Executable: /tmp/.mount_audaciXXXXXX/usr/bin/audacity Resources: /tmp/.mount_audaciXXXXXX/usr/share/* (Where 'XXXXXX' is a different alphanumeric sequence on each run.) To solve this, a PORTABLE_PREFIX is constructed at runtime by dropping the final two components of the path to the exectuable. Executable: /some/directory/bin/audacity PORTABLE_PREFIX: /some/directory (dropped '/bin/audacity') Resources: /some/directory/share/* This enables Audacity to find the resources even if they are moved, as long as the executable and resources are moved together (i.e. their location relative to each other stays the same), which is the case with the AppImage. As a fallback in case the executable and resources become separated (i.e. their location relative to each other changes) Audacity will revert back to using the fixed location specified by INSTALL_PREFIX. Fix audacity#1382.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
crsib commentedJul 29, 2021
AppImage only contains English localization.
Expected behavior
AppImage is localized to all supported languages
The text was updated successfully, but these errors were encountered: