Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Curve EQ will crash if there is an envelope point outside of the selection #1477

Closed
crsib opened this issue Aug 13, 2021 · 1 comment · Fixed by #1502
Closed

Filter Curve EQ will crash if there is an envelope point outside of the selection #1477

crsib opened this issue Aug 13, 2021 · 1 comment · Fixed by #1502
Labels
P2 High priority bugs
Milestone

Comments

@crsib
Copy link
Member

crsib commented Aug 13, 2021

Describe the bug
Filter Curve EQ will crash if there is an envelope point outside of the selection

To Reproduce
Steps to reproduce the behavior:

  1. Get some audio
  2. Use envelope tool, generate some points
  3. Select audio with an envelope point outside of the selection
  4. Apply Filter Curve EQ
  5. Observe

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information (please complete the following information):

  • OS: [e.g. Mac High Sierra, Ubuntu 18.04, Windows 10]
  • Version [e.g. Audacity 2.5.1]
  • (if relevant) Sound Device [e.g. Windows WASAPI, USB Sound card]

Additional context
Add any other context about the problem here.

@crsib crsib added P2 High priority bugs Bug severity: High labels Aug 13, 2021
@crsib crsib added this to To do (Dev) in Release 3.1 via automation Aug 13, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Aug 13, 2021

I do not see this crash on W10 with 3.3.0/3.0.4 alpha audacity-win-3.0.4-alpha-20210813+4058470-64bit

But the before and after does look odd (probably not correct)

Before EQ
image

After EQ
image

In particular the discontinuous envelope does not look right to me,

@AnitaBats AnitaBats added this to the Audacity 3.1 milestone Aug 23, 2021
@AnitaBats AnitaBats removed this from To do (Dev) in Release 3.1 Aug 23, 2021
@AnitaBats AnitaBats added this to To do in Sprint 4 - Release 3.1 via automation Aug 23, 2021
@AnitaBats AnitaBats moved this from To do to Reviewer approved in Sprint 4 - Release 3.1 Aug 23, 2021
@AnitaBats AnitaBats moved this from Reviewer approved to Ready for QA in Sprint 4 - Release 3.1 Aug 23, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 4 - Release 3.1 Aug 26, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 4 - Release 3.1 Aug 26, 2021
@Penikov Penikov closed this as completed Aug 26, 2021
Sprint 4 - Release 3.1 automation moved this from Done to Ready for QA Aug 26, 2021
@Penikov Penikov moved this from Ready for QA to Done in Sprint 4 - Release 3.1 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High priority bugs
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants