Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch processing interrupted if sample rate too high for MP3 Export #1624

Closed
SteveDaulton opened this issue Sep 5, 2021 · 1 comment · Fixed by #1656
Closed

Batch processing interrupted if sample rate too high for MP3 Export #1624

SteveDaulton opened this issue Sep 5, 2021 · 1 comment · Fixed by #1656
Labels
bug An error, undesired behaviour, or missed functionality P3 Medium Priority bugs
Milestone

Comments

@SteveDaulton
Copy link
Member

SteveDaulton commented Sep 5, 2021

Describe the bug
When batch processing, if the export format is MP3 and the sample rate of the file is too high for the selected MP3 options, or greater than 48 kHz, then batch processing is interrupted - prompting the user to manually enter a lower sample rate.

To Reproduce
Steps to reproduce the behavior:

  1. Apply "MP3 Conversion" macro to "Files" and select a file that has a sample rate > 48 kHz.
  2. Observe that the batch processing stops to ask for a lower sample rate.

Expected behavior
Audacity to automatically select an appropriate sample rate when MP3 encoding as a batch process.

Screenshots
prompt

Additional information (please complete the following information):

  • OS: Xubuntu 20.04
  • Version audacity-linux-3.0.4-x86_64.AppImage

Additional context
In most cases, the "suggested" sample rate of 8000 Hz is the worst possible option. Better to default to the highest supported sample rate rather than the lowest.

@petersampsonaudacity petersampsonaudacity added bug An error, undesired behaviour, or missed functionality P3 Medium Priority bugs labels Sep 6, 2021
@SteveDaulton
Copy link
Member Author

SteveDaulton commented Sep 6, 2021

There is now an experimental plug-in that overcomes this limitation (https://forum.audacityteam.org/viewtopic.php?p=434518#p434518) but it would be better if the solution was built in rather than requiring an additional plug-in.

pgirikishore added a commit to pgirikishore/audacity that referenced this issue Sep 10, 2021
@pgirikishore pgirikishore mentioned this issue Sep 10, 2021
6 tasks
Paul-Licameli pushed a commit that referenced this issue Dec 7, 2021
@Paul-Licameli Paul-Licameli added this to To do in Sprint 9 - 3.2 release needed R&D via automation Dec 7, 2021
@Paul-Licameli Paul-Licameli moved this from To do to Review in progress in Sprint 9 - 3.2 release needed R&D Dec 7, 2021
@Paul-Licameli Paul-Licameli moved this from Review in progress to Reviewer approved in Sprint 9 - 3.2 release needed R&D Dec 7, 2021
@Paul-Licameli Paul-Licameli moved this from Reviewer approved to Ready for QA in Sprint 9 - 3.2 release needed R&D Dec 7, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 10 - Enhancements&Bug fixes Dec 7, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 9 - 3.2 release needed R&D Dec 7, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 9 - 3.2 release needed R&D Dec 7, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 10 - Enhancements&Bug fixes Dec 9, 2021
@LWinterberg LWinterberg added this to the Audacity 3.2 milestone Dec 15, 2021
Sprint 10 - Enhancements&Bug fixes automation moved this from Done to Ready for QA Dec 15, 2021
@LWinterberg LWinterberg moved this from Ready for QA to Done in Sprint 10 - Enhancements&Bug fixes Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality P3 Medium Priority bugs
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants