Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong manual extract dir #1917

Closed
jurakovic opened this issue Oct 13, 2021 · 4 comments · Fixed by #1941
Closed

Wrong manual extract dir #1917

jurakovic opened this issue Oct 13, 2021 · 4 comments · Fixed by #1941
Assignees
@crsib
Labels
bug An error, undesired behaviour, or missed functionality P2 High priority bugs
Projects
Sprint 7 - Release 3.1
Milestone
Audacity 3.1

Comments

@jurakovic
Copy link

jurakovic commented Oct 13, 2021

Manual not extracted to /manual, but to /manual/manual, and effectively doubling release size

image

image
@crsib crsib self-assigned this Oct 13, 2021
@crsib crsib added P2 High priority bugs release 3.1 labels Oct 13, 2021
@crsib crsib added this to To do in Sprint 7 - Release 3.1 via automation Oct 13, 2021
@crsib crsib added this to the Audacity 3.1 milestone Oct 13, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Oct 13, 2021

confirmed on W10 with 3.0.5

image

@petersampsonaudacity petersampsonaudacity added the bug An error, undesired behaviour, or missed functionality label Oct 13, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Oct 15, 2021

This issues is still present in the latest 3.1.0 branch

@petersampsonaudacity
Copy link

petersampsonaudacity commented Oct 15, 2021

Tested with latest 3.1.0 Beta https://github.com/audacity/audacity/actions/runs/1345987751

This is still the case with a duplicate copy of then manual directory:
image

@crsib crsib moved this from To do to In progress in Sprint 7 - Release 3.1 Oct 15, 2021
@crsib crsib mentioned this issue Oct 15, 2021
Merged
6 tasks
@LWinterberg LWinterberg linked a pull request Oct 17, 2021 that will close this issue
Manual packaging fix #1941
Merged
6 tasks
@crsib crsib moved this from In progress to Ready for QA in Sprint 7 - Release 3.1 Oct 19, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 7 - Release 3.1 Oct 19, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 7 - Release 3.1 Oct 19, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Oct 19, 2021

@crsib Dmitry,

Testing on W10 with latest 3.1.0 build
https://github.com/audacity/audacity/actions/runs/1358692386

This looks to be properly fixed:
image

Sprint 7 - Release 3.1 automation moved this from Done to Ready for QA Oct 19, 2021
@LWinterberg LWinterberg moved this from Ready for QA to Done in Sprint 7 - Release 3.1 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crsib crsib

Labels
bug An error, undesired behaviour, or missed functionality P2 High priority bugs
Projects
No open projects
Sprint 7 - Release 3.1
Done
Milestone
Audacity 3.1
Development

Successfully merging a pull request may close this issue.

Manual packaging fix crsib/audacity
4 participants
@crsib @jurakovic @petersampsonaudacity @LWinterberg