Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach at silences. Audacity crashes with clips that trimmed and overlapped #2072

Closed
Penikov opened this issue Nov 2, 2021 · 0 comments
Closed
Assignees
Labels
bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P1 Highest level priority (ship blocker / must fix)

Comments

@Penikov
Copy link
Contributor

Penikov commented Nov 2, 2021

Describe the bug
Audacity crashes with clips that trimmed and overlapped

To Reproduce
Steps to reproduce the behaviour:

  1. Generate a clip

  2. Select the clip this way:
    изображение

  3. Apply Noise gate effect to the selection

  4. Try to apply Edit-Clip boundaries - Detach at silences

Expected behaviour
All goes well, nothing crashes.

Actual behaviour:
Audacity crashes when you try to apply Detach after Noise gate effect

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information (please complete the following information):

  • OS: Windows, Mac (just raises a message about internal error)
  • Version [e.g. Audacity 3.1 +

Additional context
UPD by Penikov:
Just a little of details:
In addition, the bug is reproducing on Windows: Audacity crashes when I tried to apply Detach Silence after the Noise Gate effect
and on Mac Audacity raises an error:

изображение

I think the root cause of poor performance is duplicating the whole selection in every clip on the track.

In the video, I trying to show how Noise Gate works with many clips.

2021-11-01.22-22-32.mp4

It is an overwhelming overhead. Also, it crashes audacity when Detach Silence tries to operate with trimmed clips.

And the combination of Noise Gate and Detwch Silence can crash Audacity even with one single clip in a project.

relates to #2051

@Penikov Penikov added bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P1 Highest level priority (ship blocker / must fix) labels Nov 2, 2021
@Penikov Penikov added this to To do in Sprint 8 - 3.1 Stabilisation via automation Nov 2, 2021
@Penikov Penikov moved this from To do to In progress in Sprint 8 - 3.1 Stabilisation Nov 2, 2021
@vsverchinsky vsverchinsky self-assigned this Nov 2, 2021
@vsverchinsky vsverchinsky moved this from In progress to Review in progress in Sprint 8 - 3.1 Stabilisation Nov 3, 2021
@AnitaBats AnitaBats moved this from Review in progress to Ready for QA in Sprint 8 - 3.1 Stabilisation Nov 9, 2021
@vsverchinsky vsverchinsky moved this from Ready for QA to Review in progress in Sprint 8 - 3.1 Stabilisation Nov 9, 2021
@vsverchinsky vsverchinsky moved this from Review in progress to Ready for QA in Sprint 8 - 3.1 Stabilisation Nov 9, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 8 - 3.1 Stabilisation Nov 9, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 8 - 3.1 Stabilisation Nov 9, 2021
Sprint 8 - 3.1 Stabilisation automation moved this from Done to Ready for QA Nov 11, 2021
@LWinterberg LWinterberg moved this from Ready for QA to Done in Sprint 8 - 3.1 Stabilisation Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P1 Highest level priority (ship blocker / must fix)
Projects
No open projects
Development

No branches or pull requests

4 participants