Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time position indicator when pointer over Timeline is missing #2122

Closed
Tracked by #2214
SteveDaulton opened this issue Nov 11, 2021 · 10 comments · Fixed by #2309
Closed
Tracked by #2214

Time position indicator when pointer over Timeline is missing #2122

SteveDaulton opened this issue Nov 11, 2021 · 10 comments · Fixed by #2309
Assignees
Labels
bug An error, undesired behaviour, or missed functionality P2 High priority bugs regression Bug is a regression against previous version

Comments

@SteveDaulton
Copy link
Member

SteveDaulton commented Nov 11, 2021

Describe the bug
When the pointer hovers over the Timeline, there should be a white vertical guide line across all tracks to clearly indicate the Quick Play position. The line does not appear

To Reproduce
Steps to reproduce the behavior:

  1. Create a project with two or more tracks
  2. Position the mouse pointer over the Timeline
  3. Observe that there is no vertical white line over the tracks

Expected behavior
See screenshot

Screenshots

indicator

Additional information (please complete the following information):

  • OS: Xubuntu 20.04
  • Version: Audacity 3.1.1
@petersampsonaudacity
Copy link

petersampsonaudacity commented Nov 12, 2021

On a related not: I observe that 3.1.x has lost the Timeline context menu command for disabling/enabling (on by default) command.

Is this a deliberate design decision, or just an error of omission ?

@Penikov Penikov added the bug An error, undesired behaviour, or missed functionality label Nov 12, 2021
@SteveDaulton
Copy link
Member Author

SteveDaulton commented Nov 28, 2021

Another user going back to an old version of Audacity because of this bug: https://forum.audacityteam.org/viewtopic.php?p=440414#p440414

@petersampsonaudacity petersampsonaudacity added regression Bug is a regression against previous version P2 High priority bugs labels Nov 28, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Nov 28, 2021

Testing on W10 - this is a regression on 3.0.5 which was the last release that had the white line - marking this as P2 die to the regression (an based on the large number of complaints on the Forum - many of which result in the user(s) reverting from 3.1 to an earlier Audacity version.

Flagging @Tantacrul as this is a UX, usability, issue.

@petersampsonaudacity
Copy link

petersampsonaudacity commented Nov 28, 2021

This is almost certainly brought about as a result of playback changes made for the new looping in 3.1.x

@lauriecooper
Copy link

lauriecooper commented Nov 29, 2021

I hope that this bug is soon fixed because I find this tool extremely useful. I'm staying with 3.0.5 until it is fixed.

@crsib
Copy link
Member

crsib commented Nov 29, 2021

@Tantacrul

@Tantacrul
Copy link

Tantacrul commented Nov 30, 2021

Yes, the little white indicator line was an unfortunately overlooked casualty. We should definitely put it back in when the user is hovering over the timeline. I think that this, in combination with the threshold work (#2182 (comment)), and anything else pressing, should be packaged into another patch release soon.

@LWinterberg LWinterberg mentioned this issue Dec 1, 2021
11 tasks
@AnitaBats AnitaBats added this to To do in Sprint 10 - Enhancements&Bug fixes via automation Dec 2, 2021
@AnitaBats AnitaBats added this to the Audacity 3.1.3 milestone Dec 2, 2021
@AnitaBats AnitaBats moved this from To do to In progress in Sprint 10 - Enhancements&Bug fixes Dec 15, 2021
@Paul-Licameli Paul-Licameli mentioned this issue Dec 19, 2021
6 tasks
@Paul-Licameli Paul-Licameli moved this from In progress to Review in progress in Sprint 10 - Enhancements&Bug fixes Dec 19, 2021
@crsib crsib moved this from Review in progress to Reviewer approved in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
@AnitaBats AnitaBats moved this from Reviewer approved to Ready for QA in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Dec 20, 2021

Testing on W10 with @Paul-Licameli 's branch build Audacity_Windows_64bit_1598995362_84704ab

this looks to be fixed, tested with all four themes
image

@Penikov Penikov moved this from Ready for QA to In QA in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
@Paul-Licameli Paul-Licameli moved this from In QA to Reviewer approved in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
@Paul-Licameli Paul-Licameli moved this from Reviewer approved to Review in progress in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
@AnitaBats AnitaBats moved this from Review in progress to Reviewer approved in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
Sprint 10 - Enhancements&Bug fixes automation moved this from Reviewer approved to Ready for QA Dec 20, 2021
@lauriecooper
Copy link

lauriecooper commented Dec 20, 2021

@Penikov Penikov moved this from Ready for QA to In QA in Sprint 10 - Enhancements&Bug fixes Dec 20, 2021
@petersampsonaudacity
Copy link

petersampsonaudacity commented Dec 20, 2021

Tested on W10 with latest 3.1.3 alpha build Audacity_Windows_64bit_1602134390_7887ba0

This looks good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality P2 High priority bugs regression Bug is a regression against previous version
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

9 participants