Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry] Audacity crashes when releasing the clip handle #2147

Closed
crsib opened this issue Nov 16, 2021 · 2 comments · Fixed by #2160
Closed

[Sentry] Audacity crashes when releasing the clip handle #2147

crsib opened this issue Nov 16, 2021 · 2 comments · Fixed by #2160
Assignees
Labels
crash / freeze catastrophic errors P1 Highest level priority bugs (ship blocker / must fix)

Comments

@crsib
Copy link
Member

crsib commented Nov 16, 2021

OS Version: Windows 10.0.19043 (None)
Report Version: 104

Crashed Thread: 14900

Application Specific Information:
Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ

Thread 14900 Crashed:
0   *************************\Audacity.exe0x7ff7bdbf614e      [inlined] std::_Ptr_base<T>::_Construct_from_weak (memory:1322)
1   *************************\Audacity.exe0x7ff7bdbf614e      [inlined] std::weak_ptr<T>::lock (memory:3050)
2   *************************\Audacity.exe0x7ff7bdbf614e      [inlined] Track::GetOwner (Track.h:379)
3   *************************\Audacity.exe0x7ff7bdbf614e      TrackList::Channels<T> (Track.h:1487)
4   *************************\Audacity.exe0x7ff7bdbfa1d4      SelectionState::SelectTrack (SelectionState.cpp:57)
5   *************************\Audacity.exe0x7ff7bdf0a9fc      AffordanceHandle::Release (AffordanceHandle.cpp:80)
6   *************************\Audacity.exe0x7ff7bdb3d5f3      CellularPanel::OnMouseEvent (CellularPanel.cpp:814)
7   *************************\wxbase313u_vc_x64_custom.dll0x7ffc0ca114a3      wxAppConsoleBase::CallEventHandler (appbase.cpp:669)
8   *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cb3c733      wxEvtHandler::ProcessEventIfMatchesId (event.cpp:1415)
9   *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cb3c2ab      wxEventHashTable::HandleEvent (event.cpp:1023)
10  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cb3dbcc      wxEvtHandler::TryHereOnly (event.cpp:1612)
11  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cb3c7a4      wxEvtHandler::ProcessEventLocally (event.cpp:1545)
12  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cb3c65b      wxEvtHandler::ProcessEvent (event.cpp:1518)
13  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cb3d769      wxEvtHandler::SafelyProcessEvent (event.cpp:1636)
14  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc099fe1a2      wxWindow::HandleMouseEvent (window.cpp:5875)
15  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a04657      wxWindow::MSWHandleMessage (window.cpp:3154)
16  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a074e7      wxWindow::MSWWindowProc (window.cpp:3877)
17  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a0d6ff      wxWndProc (window.cpp:2940)
18  *******************\user32.dll  0x7ffc93fbe7e7      UserCallWinProcCheckWow
19  *******************\user32.dll  0x7ffc93fbe228      DispatchMessageWorker
20  *******************\user32.dll  0x7ffc93fbbfdf      IsDialogMessageW
21  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a06566      wxWindow::MSWSafeIsDialogMessage (window.cpp:2805)
22  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a0608e      wxWindow::MSWProcessMessage (window.cpp:2689)
23  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a19f7e      wxGUIEventLoop::PreProcessMessage (evtloop.cpp:145)
24  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a1a041      wxGUIEventLoop::ProcessMessage (evtloop.cpp:163)
25  *************************\wxmsw313u_core_vc_x64_custom.dll0x7ffc09a1977c      wxGUIEventLoop::Dispatch (evtloop.cpp:227)
26  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0ca50074      wxEventLoopManual::ProcessEvents (evtloopcmn.cpp:237)
27  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0ca4fe7d      wxEventLoopManual::DoRun (evtloopcmn.cpp:283)
28  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0ca5013b      wxEventLoopBase::Run (evtloopcmn.cpp:90)
29  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0ca1474b      wxAppConsoleBase::MainLoop (appbase.cpp:380)
30  *************************\Audacity.exe0x7ff7bdb0b2e9      AudacityApp::OnRun (AudacityApp.cpp:1652)
31  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0caa1dd9      wxEntryReal (init.cpp:507)
32  *************************\wxbase313u_vc_x64_custom.dll0x7ffc0cba8ff7      wxEntry (main.cpp:184)
33  *************************\Audacity.exe0x7ff7be1280d9      [inlined] invoke_main (exe_common.inl:102)
34  *************************\Audacity.exe0x7ff7be1280d9      __scrt_common_main_seh (exe_common.inl:288)
35  *******************\kernel32.dll0x7ffc92347033      BaseThreadInitThunk
36  *******************\ntdll.dll   0x7ffc94222650      RtlUserThreadStart

STR:

  1. Create the new track and create a new clip in it
  2. Start recording (make sure that you are recording to the same track)
  3. Try to simultaneously do the following: stop recording (Spacebar) and click on the first clip's handle
@crsib crsib added P1 Highest level priority bugs (ship blocker / must fix) crash / freeze catastrophic errors labels Nov 16, 2021
@AnitaBats AnitaBats added this to To do in Sprint 8 - 3.1 Stabilisation via automation Nov 16, 2021
@AnitaBats AnitaBats added this to the Audacity 3.1.3 milestone Nov 16, 2021
@AnitaBats AnitaBats moved this from To do to In progress in Sprint 8 - 3.1 Stabilisation Nov 16, 2021
@vsverchinsky vsverchinsky moved this from In progress to Review in progress in Sprint 8 - 3.1 Stabilisation Nov 18, 2021
@vsverchinsky vsverchinsky moved this from Review in progress to Reviewer approved in Sprint 8 - 3.1 Stabilisation Nov 19, 2021
@AnitaBats AnitaBats moved this from Reviewer approved to Ready for QA in Sprint 8 - 3.1 Stabilisation Nov 19, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 8 - 3.1 Stabilisation Nov 22, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 8 - 3.1 Stabilisation Nov 22, 2021
@LWinterberg LWinterberg linked a pull request Nov 22, 2021 that will close this issue
6 tasks
@petersampsonaudacity
Copy link

petersampsonaudacity commented Nov 22, 2021

I tested this with @vsverchinsky Vitaly's branch build: audacity-win-3.1.3-alpha-20211119+d998117-64bit

Testing on W10 I get no crash with this build - I do get the crash with 3.1.2

@petersampsonaudacity
Copy link

petersampsonaudacity commented Nov 23, 2021

Testing the 3.1.3 Beta-1 on W10
https://github.com/audacity/audacity/releases/tag/Audacity-3.1.3-beta-1

I get no crash with this Beta build - I do get the crash with 3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash / freeze catastrophic errors P1 Highest level priority bugs (ship blocker / must fix)
Projects
No open projects
5 participants