Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clip Names. Audacity crashes when a user clicks 'Cancel' at clip renaming dialog #2198

Closed
Penikov opened this issue Nov 29, 2021 · 1 comment · Fixed by #2249
Closed

Clip Names. Audacity crashes when a user clicks 'Cancel' at clip renaming dialog #2198

Penikov opened this issue Nov 29, 2021 · 1 comment · Fixed by #2249
Assignees
@vsverchinsky
Labels
bug An error, undesired behaviour, or missed functionality Clips crash / freeze catastrophic errors P1 Highest level priority bugs (ship blocker / must fix)
Projects
Sprint 10 - Enhancements&Bug fixes
Milestone
Audacity 3.1.3

Comments

@Penikov
Copy link
Contributor

Penikov commented Nov 29, 2021 •
edited

Describe the bug

Audacity crashes when a user clicks 'Cancel' at clip renaming dialog

To Reproduce
Steps to reproduce the behaviour:

  1. Add a couple of tracks with clips

  2. Turn On [Menu]-[Tracks]-[Sync Lock Tracks]

  3. Go to [Preferences]-[Tracks]-[Tracks Behaviors] turn on the tickbox "use the dialogue for the name of new label"
    изображение

  4. Open the 'Set wave clip name' dialog with Double-click

  5. Click the 'Cancel' button and close the dialog

Additional information (please complete the following information):

  • OS: Windows 10, Mac OS Monterey
  • Version: Audacity 3.1.2 +

Additional context

Steps to reproduce on Windows: are the same, except the last step.
The last step on Windows should be:
5. Click the 'Close' button
изображение

relates to #2199

More details: https://youtu.be/trb0yqqw96Q?t=340
@Penikov Penikov added bug An error, undesired behaviour, or missed functionality P1 Highest level priority bugs (ship blocker / must fix) crash / freeze catastrophic errors labels Nov 29, 2021
@Penikov Penikov mentioned this issue Nov 29, 2021
Closed
@LWinterberg LWinterberg added the macOS Bugs only affecting macOS systems label Dec 2, 2021
@AnitaBats AnitaBats removed the macOS Bugs only affecting macOS systems label Dec 2, 2021
@AnitaBats
Copy link

AnitaBats commented Dec 2, 2021

reproducible on Windows as well

@AnitaBats AnitaBats added this to the Audacity 3.1.3 milestone Dec 2, 2021
@AnitaBats AnitaBats added this to To do in Sprint 10 - Enhancements&Bug fixes via automation Dec 2, 2021
@vsverchinsky vsverchinsky moved this from To do to In progress in Sprint 10 - Enhancements&Bug fixes Dec 6, 2021
@vsverchinsky vsverchinsky mentioned this issue Dec 8, 2021
Merged
6 tasks
@vsverchinsky vsverchinsky moved this from In progress to Review in progress in Sprint 10 - Enhancements&Bug fixes Dec 8, 2021
@LWinterberg LWinterberg linked a pull request Dec 8, 2021 that will close this issue
Issue 2198: fix clip rename #2249
Merged
6 tasks
vsverchinsky added a commit that referenced this issue Dec 10, 2021
@vsverchinsky
Merge pull request #2249 from vsverchinsky/i2198-fix-clip-rename2
3fa7d62 
Issue #2198, #2199: fix clip rename

Interaction with modal dialog causes Cancel event to be dispatched before dialog itself is finished (easily reproducible in MacOS). Then ProjectHistory::Rollback in TimeShiftHandle::Cancel replaces all tracks in the current track list, so that track captured by TimeShiftHandle becomes orphaned. Another issue is that returning RefreshCode::Cancelled from WaveTrackAffordanceHandle::Click also causes ProjectHistory::Rollback and as a result tracks changes made to the clip name reverted.
@vsverchinsky vsverchinsky moved this from Review in progress to Ready for QA in Sprint 10 - Enhancements&Bug fixes Dec 10, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 10 - Enhancements&Bug fixes Dec 10, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 10 - Enhancements&Bug fixes Dec 10, 2021
Sprint 10 - Enhancements&Bug fixes automation moved this from Done to Ready for QA Dec 15, 2021
@LWinterberg LWinterberg moved this from Ready for QA to Done in Sprint 10 - Enhancements&Bug fixes Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsverchinsky vsverchinsky

Labels
bug An error, undesired behaviour, or missed functionality Clips crash / freeze catastrophic errors P1 Highest level priority bugs (ship blocker / must fix)
Projects
No open projects
Sprint 10 - Enhancements&Bug fixes
Done
Milestone
Audacity 3.1.3
Development

Successfully merging a pull request may close this issue.

Issue 2198: fix clip rename vsverchinsky/audacity
5 participants
@vsverchinsky @Penikov @petersampsonaudacity @AnitaBats @LWinterberg