Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Clip names can't be renamed at sync-locked tracks on macOS #2199

Closed
Penikov opened this issue Nov 29, 2021 · 0 comments · Fixed by #2249
Closed

Mac Clip names can't be renamed at sync-locked tracks on macOS #2199

Penikov opened this issue Nov 29, 2021 · 0 comments · Fixed by #2249
Assignees
Labels
bug An error, undesired behaviour, or missed functionality Clips P2 High priority bugs

Comments

@Penikov
Copy link
Contributor

Penikov commented Nov 29, 2021

Describe the bug
Clip names couldn't be renamed at sync-locked tracks on Mac OS

To Reproduce
Steps to reproduce the behaviour:

  1. Add a couple of tracks with clips

  2. Turn On [Menu]-[Tracks]-[Sync Lock Tracks]

  3. Try to rename the clip

If you click the 'cancel' button, Audacity will crash. This is another issue: #2198

Expected behaviour

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information (please complete the following information):

  • OS: Mac OS Monterey
  • Version: Audacity 3.1.2+
@Penikov Penikov added bug An error, undesired behaviour, or missed functionality P2 High priority bugs Clips labels Nov 29, 2021
@petersampsonaudacity petersampsonaudacity changed the title Clip Names. Clip names are couldn't be renamed at sync-locked tracks Mac Clip names can't be renamed at sync-locked tracks on macOS Dec 1, 2021
@AnitaBats AnitaBats added this to To do in Sprint 10 - Enhancements&Bug fixes via automation Dec 2, 2021
@AnitaBats AnitaBats added this to the Audacity 3.1.3 milestone Dec 2, 2021
@AnitaBats AnitaBats moved this from To do to In progress in Sprint 10 - Enhancements&Bug fixes Dec 7, 2021
@vsverchinsky vsverchinsky moved this from In progress to Review in progress in Sprint 10 - Enhancements&Bug fixes Dec 8, 2021
@LWinterberg LWinterberg linked a pull request Dec 8, 2021 that will close this issue
6 tasks
vsverchinsky added a commit that referenced this issue Dec 10, 2021
Issue #2198, #2199: fix clip rename

Interaction with modal dialog causes Cancel event to be dispatched before dialog itself is finished (easily reproducible in MacOS). Then ProjectHistory::Rollback in TimeShiftHandle::Cancel replaces all tracks in the current track list, so that track captured by TimeShiftHandle becomes orphaned. Another issue is that returning RefreshCode::Cancelled from WaveTrackAffordanceHandle::Click also causes ProjectHistory::Rollback and as a result tracks changes made to the clip name reverted.
@vsverchinsky vsverchinsky moved this from Review in progress to Ready for QA in Sprint 10 - Enhancements&Bug fixes Dec 10, 2021
@Penikov Penikov moved this from Ready for QA to In QA in Sprint 10 - Enhancements&Bug fixes Dec 10, 2021
@Penikov Penikov moved this from In QA to Done in Sprint 10 - Enhancements&Bug fixes Dec 10, 2021
Sprint 10 - Enhancements&Bug fixes automation moved this from Done to Ready for QA Dec 15, 2021
@LWinterberg LWinterberg moved this from Ready for QA to Done in Sprint 10 - Enhancements&Bug fixes Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, undesired behaviour, or missed functionality Clips P2 High priority bugs
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants