Crash when cancelling Nyquist Prompt #2239
Assignees
Labels
bug
An error, undesired behaviour, or missed functionality
P1
Highest level priority bugs (ship blocker / must fix)
regression
Bug is a regression against previous version
Projects
Milestone
Comments
SteveDaulton
added
bug
Paul-Licameli
added a commit
to Paul-Licameli/audacity
that referenced
this issue
Dec 5, 2021
... To reproduce: * Generate a tone * Open the Nyquist Prompt and enter the code: ``` ;control test "Test" float "" 5 0 10 (print test) ``` * Click the "OK" button * Click the "Cancel" button * Observe crash Bug was introduced at b1e988e The nulling-out of a pointer to the Effect in the Close routine was deleted, but the destructor is still called later. To fix it, don't unnecessarily repeat in the destructor of the modal dialog (which may be delayed until an event loop) what was already done when closing it.
6 tasks
|
I introduced this bug. It happens only in the development branch. See the linked PR for the fix. |
AnitaBats
moved this from In progress
to Review in progress
in Sprint 10 - Enhancements&Bug fixes
Paul-Licameli
added a commit
to Paul-Licameli/audacity
that referenced
this issue
Dec 9, 2021
... To reproduce: * Generate a tone * Open the Nyquist Prompt and enter the code: ``` ;control test "Test" float "" 5 0 10 (print test) ``` * Click the "OK" button * Click the "Cancel" button * Observe crash Bug was introduced at b1e988e The nulling-out of a pointer to the Effect in the Close routine was deleted, but the destructor is still called later. To fix it, don't unnecessarily repeat in the destructor of the modal dialog (which may be delayed until an event loop) what was already done when closing it.
Paul-Licameli
added a commit
to Paul-Licameli/audacity
that referenced
this issue
Dec 10, 2021
... To reproduce: * Generate a tone * Open the Nyquist Prompt and enter the code: ``` ;control test "Test" float "" 5 0 10 (print test) ``` * Click the "OK" button * Click the "Cancel" button * Observe crash Bug was introduced at b1e988e The nulling-out of a pointer to the Effect in the Close routine was deleted, but the destructor is still called later. To fix it, don't unnecessarily repeat in the destructor of the modal dialog (which may be delayed until an event loop) what was already done when closing it.
Sprint 10 - Enhancements&Bug fixes
automation
moved this from Review in progress
to Ready for QA
Dec 10, 2021
Paul-Licameli
added a commit
that referenced
this issue
Dec 10, 2021
... To reproduce: * Generate a tone * Open the Nyquist Prompt and enter the code: ``` ;control test "Test" float "" 5 0 10 (print test) ``` * Click the "OK" button * Click the "Cancel" button * Observe crash Bug was introduced at b1e988e The nulling-out of a pointer to the Effect in the Close routine was deleted, but the destructor is still called later. To fix it, don't unnecessarily repeat in the destructor of the modal dialog (which may be delayed until an event loop) what was already done when closing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SteveDaulton commentedDec 5, 2021
•
edited
Describe the bug
When cancelling the Nyquist Prompt, Audacity may crash
To Reproduce
Steps to reproduce the behavior:
;control test "Test" float "" 5 0 10
(print test)
Expected behavior
Not crash
Screenshots
If applicable, add screenshots to help explain your problem.
Additional information (please complete the following information):
Additional context
This is a regression
The text was updated successfully, but these errors were encountered: