Dynamic library path does not change unless using "Browse..." dialog

[wildwestrom]

Is your feature request related to a problem? Please describe.
There's a link to download a .pkg file containing dynamic libraries required for audacity to work. These are outdated, and probably the reason why I can't import various formats supported by ffmpeg (opus for example).
When I try to point to the path $HOMEBREW_PREFIX/Cellar/ffmpeg/4.4.1/lib/*.dylib nothing happens, it uses the same path as before.

Describe the solution you'd like
I'd much rather use the libraries provided by the homebrew package. This way I can use the latest stable or nightly release of ffmpeg.

Describe alternatives you've considered
I thought to try compiling the libraries myself, but I don't know how to do it in such a way that Audacity will accept the libs. It looks like it's expecting these three:
ffmpeg.55.64bit.dylib ffmpeg_utils.52.64bit.dylib ffmpeg_codecs.55.64bit.dylib
Homebrew creates these:

main@MacBook ~/h/C/f/4/lib> ls
libavformat.58.76.100.dylib  libpostproc.55.dylib
libavcodec.58.134.100.dylib  libavformat.58.dylib         libpostproc.a
libavcodec.58.dylib          libavformat.a                libpostproc.dylib
libavcodec.a                 libavformat.dylib            libswresample.3.9.100.dylib
libavcodec.dylib             libavresample.4.0.0.dylib    libswresample.3.dylib
libavdevice.58.13.100.dylib  libavresample.4.dylib        libswresample.a
libavdevice.58.dylib         libavresample.a              libswresample.dylib
libavdevice.a                libavresample.dylib          libswscale.5.9.100.dylib
libavdevice.dylib            libavutil.56.70.100.dylib    libswscale.5.dylib
libavfilter.7.110.100.dylib  libavutil.56.dylib           libswscale.a
libavfilter.7.dylib          libavutil.a                  libswscale.dylib
libavfilter.a                libavutil.dylib
libavfilter.dylib            libpostproc.55.9.100.dylib

It seems Audacity is hardcoded to only accept certain filenames:

audacity/src/FFmpeg.cpp

Lines 180 to 192 in 0b3ba4f

	void OnBrowse(wxCommandEvent & WXUNUSED(event))
	{
	static const FileNames::FileTypes types = {
	# if defined(__WXMSW__)
	{ XO("Only avformat.dll"), { wxT("avformat-*.dll") } },
	# elif defined(__WXMAC__)
	{ XO("Only ffmpeg.*.dylib"), { wxT("ffmpeg.*.dylib") } },
	# else
	{ XO("Only libavformat.so"), { wxT("libavformat.so.*") } },
	# endif
	FileNames::DynamicLibraries,
	FileNames::AllFiles
	};

audacity/libraries/lib-ffmpeg-support/FFmpegFunctions.cpp

Lines 125 to 137 in b630259

	std::vector<wxString> BuildAVFormatPaths(int version)
	{
	return {
	#if defined(__WXMSW__)
	wxString::Format("avformat-%d.dll", version),
	#elif defined(__WXMAC__)
	wxString::Format("ffmpeg.%d.64bit.dylib", version),
	wxString::Format("libavformat.%d.dylib", version),
	#else
	wxString::Format("libavformat.so.%d", version)
	#endif
	};
	}

Additional context
N/A, maybe later

[crsib]

Audacity 3.1+ should be able to load libavformat.58.dylib just fine (i.e., just pasting the full path should help), although the "FindFFmpegDialog" dialog needs fixing...

I will check, but just one small question - do you have an Intel Mac?

[wildwestrom]

@crsib Yes, it is an Intel Mac.

[wildwestrom]

Ok, it seems to load libavformat.dylib okay.
I had to navigate manually instead of putting in the full path.

Opus audio also imports without any problem.

[wildwestrom]

It should either be clear that the text box to input the path does nothing, or fix that functionality. Right now the only way to change the dylib path is to use the Browse... dialog.

Audacity 3.1.2
MacOS 12.0.1 (Intel)

I also think there should be some documentation on how to use ffmpeg via Homebrew on the wiki.

Steps to reproduce:

• Navigate to:
  • Preferences
  • Libraries
• Click Locate...
• Click Yes
• Put full path to the dynamic library directory in the text box under Location of 'ffmpeg.*.64bit.dylib':
• E.g. /Library/Application Support/audacity/libs
/Library/Application Support/audacity/libs/
/Library/Application Support/audacity/libs/*
• Click Ok

Expected:
Library version and path to library changes.
Actual:
Library version and path to library does not change.

Workaround:

• Use Browse... dialog.
• Navigate to the directory containing the libs.
• Select one of the .dylib files.

[crsib]

I was sure it was fixed. I will recheck

[crsib]

Turns out that the check was very confusing (and quite wrong). It was expected that the path would be a full path to a dylib.