Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED meters (as in DarkAudacity) #2558

Closed
petersampsonaudacity opened this issue Feb 15, 2022 · 5 comments
Closed

LED meters (as in DarkAudacity) #2558

petersampsonaudacity opened this issue Feb 15, 2022 · 5 comments
Labels
Design / UX Bugs, enhancement requests and tasks a designer should look at Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. medium feature medium-impact feature

Comments

@petersampsonaudacity
Copy link

petersampsonaudacity commented Feb 15, 2022

Describe the bug
LED meters (as in DarkAudacity) - this would give the GUI a nice refresh giving the meters a more modern look - a more "digital look".

To Reproduce
Steps to reproduce the behavior:

  1. Install DarkAudacity - http://www.darkaudacity.com/download.html
  2. launch
  3. Import some audio
  4. Press Play
  5. Observe the LED default meters (see Screenshot 1)
  6. Click on the loudspeaker icon in the Playback meter
  7. Select Options
  8. Observe the options dialog defaults to LED - but retains the current Audacity default RMS and the older, original, Audacity Gradient metering - see Screenshot 3

Note that the meters can be floated an enlarged if required -0 see Screenshot 2

Expected behavior
An added option (on by default) for LED metering

Screenshots

1) default LED meter

image

2) enlarged, floated, LED meter

image

3) options / settings

image

Additional information (please complete the following information):

  • OS: W10 and macOS 12.2.1 Monterey - but assume all
  • Version 3.1.3/3.2.0 and earlier

Additional context
Flagging @Tantacrul as a UX/GUI issue

Note that many/most of the other features that James changed for DarkAudacity have now already migrated into mainstream Audacity (including the Dark (optional) theme) - but this one somehow escaped. See:
http://www.darkaudacity.com/download.html

James advised me of this permalink for where the LED meter code is.

//#ifdef EXPERIMENTAL_METER_LED_STYLE

He added:

[it will need] rework it as it is rough and ready and with no customisation.

Note that with this implementation (for all three metering modes in DA) James removed the numbering.
I strongly think that numbers on the meters should be retained, if only as an option.

@petersampsonaudacity petersampsonaudacity added Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. Design / UX Bugs, enhancement requests and tasks a designer should look at labels Feb 15, 2022
@petersampsonaudacity
Copy link
Author

petersampsonaudacity commented Feb 15, 2022

Aside 1

Note that as part of this rework James consolidated the meters and the Mixer toolbar thus saving some screen real estate.

Observe the orange movable sliders in the meters:
image

This does not form part of this enhancement request, but is something that could be considered for the future.

@petersampsonaudacity
Copy link
Author

petersampsonaudacity commented Feb 15, 2022

Aside 2

Note too that with this implementation James also removed the Device toolbar and placed (most) of its functionality in the meter options - but he omitted the stereo/mono setting (which I think was a serious omission).

image

Note that these settings, including the stereo/mono can be made in Devices preferences:
https://alphamanual.audacityteam.org/man/Devices_Preferences

This definitely does NOT form part of this enhancement request - but again is something that could ne considered for the future as a way of saving screen real estate,

The Device toolbar could also be retained - but then it could be turned "off" by default.

@Tantacrul
Copy link

Tantacrul commented Feb 15, 2022

I also much prefer this option to the separate sliders / input meters. Let me discuss this with the team. There's a lot of stuff in this that we were planning for the next release, although the details are a little different here and there. Thanks!

@DavidBailes
Copy link
Collaborator

DavidBailes commented Feb 16, 2022

@Tantacrul
If it's decided to combine the sliders and meters in some way, please can the design include a specification of how both the sliders and the meters remain accessible for users of screen readers. (Rather than it being left to be fixed up at some later date.)

@LWinterberg LWinterberg added this to Undecided in Feature Requests Feb 28, 2022
@LWinterberg LWinterberg moved this from Undecided to Deferred in Feature Requests Mar 2, 2022
@LWinterberg LWinterberg added the medium feature medium-impact feature label Mar 3, 2022
@LWinterberg
Copy link
Member

LWinterberg commented Apr 8, 2022

Aside 1 got spun off into #2779

We will not be adding this version of the LED meter. The LEDs are not functional (that is, they don't discretely light up but instead are just an overlay over the normal meter) and they don't appear to be tied to any meaningful volume interval (eg 1dB, 3dB).

That said, using plain color segments instead of a gradient is something we're looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design / UX Bugs, enhancement requests and tasks a designer should look at Enhancement Request Or feature requests. Open-ended requests are better suited for discussions. medium feature medium-impact feature
Projects
Status: Replaced by alternative
Development

No branches or pull requests

4 participants