Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audacity crashes when applying mono Berzerk to mono track destructively #3694

Closed
crsib opened this issue Sep 26, 2022 · 1 comment · Fixed by #3750
Closed

Audacity crashes when applying mono Berzerk to mono track destructively #3694

crsib opened this issue Sep 26, 2022 · 1 comment · Fixed by #3750
Assignees
@vsverchinsky @dozzzzer
Labels
bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P2 High priority bugs
Milestone
Audacity 3.2.1

Comments

@crsib
Copy link
Member

crsib commented Sep 26, 2022

Bug description

Unhandled exception at 0x00007FF9A0873CE7 (WavesLib1_14.0.83_Win64.dll) in Audacity.exe: 0xC000041D: An unhandled exception was encountered during a user callback.

It appears to be a stack overflow due to infinite recursion:

Fragment of stack:

 	WavesLib1_14.0.83_Win64.dll!00007ff9a0873ce7()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a0874e3e()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a0872e2e()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a0874614()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a08882d2()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a088529b()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a087dbfa()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a07a0021()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a079f76f()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a0755fce()	Unknown
 	Berzerk Distortion.dll!00007ff9a78f5299()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fa9be()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fa824()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a362()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a6ac()	Unknown
 	Berzerk Distortion.dll!00007ff9a78ffb36()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce3940()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce935f()	Unknown
>	Audacity.exe!`anonymous namespace'::SetupProcessing(Steinberg::Vst::IComponent & component, Steinberg::Vst::ProcessSetup & setup) Line 164	C++
 	Audacity.exe!VST3Wrapper::FlushParameters(EffectSettings & settings) Line 606	C++
 	Audacity.exe!`anonymous-namespace'::ComponentHandler::performEdit::__l10::<lambda>(EffectSettings & settings) Line 279	C++
 	Audacity.exe!EffectSettingsAccess::ModifySettings<``anonymous namespace'::ComponentHandler::performEdit'::`10'::std::shared_ptr<TrackView> <lambda>(Track &)>(`anonymous-namespace'::ComponentHandler::performEdit::__l10::std::shared_ptr<TrackView> <lambda>(Track &) && function) Line 152	C++
 	Audacity.exe!`anonymous namespace'::ComponentHandler::performEdit(unsigned long id, double valueNormalized) Line 282	C++
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0cd5442()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce8f25()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0e0fd93()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a07222b3()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a06f4e32()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a06f1088()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fb805()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fa851()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a362()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a6ac()	Unknown
 	Berzerk Distortion.dll!00007ff9a78ffb36()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce3940()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce935f()	Unknown
 	Audacity.exe!`anonymous namespace'::SetupProcessing(Steinberg::Vst::IComponent & component, Steinberg::Vst::ProcessSetup & setup) Line 164	C++
 	Audacity.exe!VST3Wrapper::FlushParameters(EffectSettings & settings) Line 606	C++
 	Audacity.exe!`anonymous-namespace'::ComponentHandler::performEdit::__l10::<lambda>(EffectSettings & settings) Line 279	C++
 	Audacity.exe!EffectSettingsAccess::ModifySettings<``anonymous namespace'::ComponentHandler::performEdit'::`10'::std::shared_ptr<TrackView> <lambda>(Track &)>(`anonymous-namespace'::ComponentHandler::performEdit::__l10::std::shared_ptr<TrackView> <lambda>(Track &) && function) Line 152	C++
 	Audacity.exe!`anonymous namespace'::ComponentHandler::performEdit(unsigned long id, double valueNormalized) Line 282	C++
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0cd5442()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce8f25()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0e0fd93()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a07222b3()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a06f4e32()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a06f1088()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fb805()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fa851()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a362()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a6ac()	Unknown
 	Berzerk Distortion.dll!00007ff9a78ffb36()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce3940()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce935f()	Unknown
 	Audacity.exe!`anonymous namespace'::SetupProcessing(Steinberg::Vst::IComponent & component, Steinberg::Vst::ProcessSetup & setup) Line 164	C++
 	Audacity.exe!VST3Wrapper::FlushParameters(EffectSettings & settings) Line 606	C++
 	Audacity.exe!`anonymous-namespace'::ComponentHandler::performEdit::__l10::<lambda>(EffectSettings & settings) Line 279	C++
 	Audacity.exe!EffectSettingsAccess::ModifySettings<``anonymous namespace'::ComponentHandler::performEdit'::`10'::std::shared_ptr<TrackView> <lambda>(Track &)>(`anonymous-namespace'::ComponentHandler::performEdit::__l10::std::shared_ptr<TrackView> <lambda>(Track &) && function) Line 152	C++
 	Audacity.exe!`anonymous namespace'::ComponentHandler::performEdit(unsigned long id, double valueNormalized) Line 282	C++
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0cd5442()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce8f25()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0e0fd93()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a07222b3()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a06f4e32()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a06f1088()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fb805()	Unknown
 	Berzerk Distortion.dll!00007ff9a78fa851()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a362()	Unknown
 	WavesLib1_14.0.83_Win64.dll!00007ff9a078a6ac()	Unknown
 	Berzerk Distortion.dll!00007ff9a78ffb36()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce3940()	Unknown
 	WaveShell1-VST3 14.0_x64.vst3!00007ff9a0ce935f()	Unknown
 	Audacity.exe!`anonymous namespace'::SetupProcessing(Steinberg::Vst::IComponent & component, Steinberg::Vst::ProcessSetup & setup) Line 164	C++
 	Audacity.exe!VST3Wrapper::FlushParameters(EffectSettings & settings) Line 606	C++
 	Audacity.exe!`anonymous-namespace'::ComponentHandler::performEdit::__l10::<lambda>(EffectSettings & settings) Line 279	C++
 	Audacity.exe!EffectSettingsAccess::ModifySettings<``anonymous namespace'::ComponentHandler::performEdit'::`10'::std::shared_ptr<TrackView> <lambda>(Track &)>(`anonymous-namespace'::ComponentHandler::performEdit::__l10::std::shared_ptr<TrackView> <lambda>(Track &) && function) Line 152	C++
 	Audacity.exe!`anonymous namespace'::ComponentHandler::performEdit(unsigned long id, double valueNormalized) Line 282	C++

Steps to reproduce

  1. Generate Chirp
  2. Apply Waves Berzerk Distortion Mono

Expected behavior

Effect is applied

Actual behavior

No response

Audacity Version

latest stable version (from audacityteam.org/download)

Operating system

Windows

Additional context

No response
@crsib crsib added the bug An error, undesired behaviour, or missed functionality label Sep 26, 2022
@crsib crsib added this to the Audacity 3.2.x milestone Sep 26, 2022
@crsib crsib added the P2 High priority bugs label Sep 26, 2022
@LWinterberg LWinterberg added the crash / freeze catastrophic errors label Sep 27, 2022
@vsverchinsky vsverchinsky self-assigned this Sep 27, 2022
@vsverchinsky vsverchinsky mentioned this issue Oct 3, 2022
Merged
6 tasks
@crsib crsib linked a pull request Oct 4, 2022 that will close this issue
Fixes infinite recursion/idle freeze in VST3Wrapper #3750
Merged
6 tasks
@LWinterberg
Copy link
Member

LWinterberg commented Oct 5, 2022

not yet merged

@LWinterberg LWinterberg reopened this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsverchinsky vsverchinsky

@dozzzzer dozzzzer

Labels
bug An error, undesired behaviour, or missed functionality crash / freeze catastrophic errors P2 High priority bugs
Projects
Kanban board
Status: Done
Milestone
Audacity 3.2.1
Development

Successfully merging a pull request may close this issue.

Fixes infinite recursion/idle freeze in VST3Wrapper vsverchinsky/audacity
6 participants
@crsib @vsverchinsky @dozzzzer @AnitaBats @LWinterberg @Ryan-Miller-Audacity