Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample accuracy for Rhythm Track #1853

Merged
merged 1 commit into from Oct 7, 2021
Merged

Conversation

SteveDaulton
Copy link
Member

@SteveDaulton SteveDaulton commented Oct 7, 2021

Resolves: #1837

tnzw wrote:

To me, I expect to have mathematical "perfect" timing has I am working on a computer. (i.e. for i in range(bars): at_abs = offset + i * beatlen

LWinterberg wrote:

I think that having it fully accurate is the more useful approach to put work in.

  • [x ] I signed CLA
  • [x ] The title of the pull request describes an issue it addresses
  • [x ] If changes are extensive, then there is a sequence of easily reviewable commits
  • [x ] Each commit's message describes its purpose and effects
  • [x ] There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • [x ] Each commit compiles and runs on my machine without known undesirable changes of behavior

@SteveDaulton SteveDaulton mentioned this pull request Oct 7, 2021
6 tasks
crsib
crsib approved these changes Oct 7, 2021
@crsib crsib merged commit 515b122 into audacity:master Oct 7, 2021
4 checks passed
@SteveDaulton SteveDaulton deleted the rhythmtrack branch Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants