Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a corner case when formatting number very close to 0 #2128

Merged
merged 1 commit into from Nov 16, 2021
Merged

Fixes a corner case when formatting number very close to 0 #2128

merged 1 commit into from Nov 16, 2021

Conversation

crsib
Copy link
Member

@crsib crsib commented Nov 12, 2021

If digitsAfterDecimalPoint was set, Audacity would crash if |decimal_exponent| is larger than length.

Resolves: #2127

(short description of the changes and the motivation to make the changes)

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@crsib crsib requested a review from Paul-Licameli Nov 12, 2021
@crsib crsib added this to In progress in Sprint 9 - 3.2 release needed R&D via automation Nov 12, 2021
@crsib
Fixes a corner case when formatting number very close to 0
5fbf59e 
If digitsAfterDecimalPoint was set, Audacity would crash if |decimal_exponent| is larger than length.
@crsib crsib force-pushed the 2127_tochars_maxdigits branch from 4699eb4 to 5fbf59e Compare Nov 12, 2021
@crsib crsib moved this from In progress to Review in progress in Sprint 9 - 3.2 release needed R&D Nov 15, 2021
Sprint 9 - 3.2 release needed R&D automation moved this from Review in progress to Reviewer approved Nov 16, 2021
@crsib crsib merged commit d107233 into audacity:release-3.1.2 Nov 16, 2021
4 checks passed
Sprint 9 - 3.2 release needed R&D automation moved this from Reviewer approved to Ready for QA Nov 16, 2021
@crsib crsib deleted the 2127_tochars_maxdigits branch Nov 16, 2021
@Penikov Penikov moved this from Ready for QA to Done in Sprint 9 - 3.2 release needed R&D Nov 16, 2021
@AnitaBats AnitaBats added this to the Audacity 3.1.2 milestone Nov 16, 2021
@AnitaBats AnitaBats added this to In progress in Sprint 8 - 3.1 Stabilisation via automation Nov 16, 2021
@AnitaBats AnitaBats moved this from In progress to In QA in Sprint 8 - 3.1 Stabilisation Nov 16, 2021
@AnitaBats AnitaBats moved this from In QA to Done in Sprint 8 - 3.1 Stabilisation Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Licameli Paul-Licameli

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Sprint 8 - 3.1 Stabilisation
Done
Milestone
Audacity 3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crsib @Paul-Licameli @AnitaBats