MP3 import based on libmpg123 #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksoze95
approved these changes
Jun 15, 2022
Paul-Licameli
reviewed
Jun 15, 2022
| @@ -706,7 +706,7 @@ list( APPEND SOURCES | |||
| > | |||
|
|
|||
| $<$<BOOL:${USE_LIBMAD}>: | |||
| import/ImportMP3.cpp | |||
| import/ImportMP3_MAD.cpp | |||
There was a problem hiding this comment.
The old file name is still mentioned in comments in itself and in Import.cpp.
There was a problem hiding this comment.
in comments in itself
This is fixed
There was a problem hiding this comment.
Anyway, I have restructured commits to improve it
crsib
force-pushed
the
2236_libmpg123
branch
3 times, most recently
from
8f039b6
to
b3174da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves: #2236
Resolves: #2634
Resolves: #3029
Audacity uses
libmadto import MP3 files. It seems that this library struggles to play some allegedly valid mp3 files.Similar behavior is observed when using
madplay.This PR introduces an alternative MP3 importer, based on
libmpg123, which is known to be used by major software, such as VLC.Recommended: