Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes GTK packaging on Linux #3571

Merged
merged 1 commit into from Sep 9, 2022
Merged

Conversation

crsib
Copy link
Member

@crsib crsib commented Sep 7, 2022

  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@crsib crsib requested a review from vsverchinsky Sep 7, 2022
@LWinterberg
Copy link
Member

LWinterberg commented Sep 9, 2022

While this fix seems to not apply the GTK theme properly (maybe it's some sort of fallback/default? Certainly isn't adwita-dark), it's way more usable now. Testing across the board of linux UI bugs,

I think that's all of them. I don't know how many of them should be marked as resolved by this PR :)

@crsib
Copy link
Member Author

crsib commented Sep 9, 2022

Whoa, that is quite a lot of feedback, thank you!

@crsib
Copy link
Member Author

crsib commented Sep 9, 2022

I think #1536 is about GTK3 build, we are still building GTK2. So not fixed, I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants