Ffmpeg aac m4a export #3634
Merged
Ffmpeg aac m4a export #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaced the slider with a spinctrl. The control is constraint to values between 98-320 only via the up and down arrows. The textbox is currently not validated yet, so you can enter a value outside this range. However when you press save, it will constrain the desired target kps to the nearest value inside the valid range. A later PR will be raised to have validation for the textbox as well. |
crsib
reviewed
Sep 16, 2022
src/export/ExportFFmpegDialogs.cpp
Outdated
| XXO("Quality (kbps):"), | ||
| {wxT("/FileFormats/AACQuality"), 160},320, 98); | ||
| S.TieSpinCtrl( | ||
| XXO("Quality (kbps)"), |
There was a problem hiding this comment.
Is changing this line necessary?
There was a problem hiding this comment.
Nope. Forgot to undo change. Will fix it up now.
... format is no longer is ignored.
ksoze95
requested review from
crsib and
Paul-Licameli
and removed request for
Paul-Licameli and
crsib
crsib
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Resolves: #1818
(short description of the changes and the motivation to make the changes)
Recommended: