-
Notifications
You must be signed in to change notification settings - Fork 0
Use uv instead of pip #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR replaces pip-based dependency management and CI steps with uv-driven workflows by defining a dev group in pyproject.toml, removing legacy requirements files, updating CONTRIBUTING instructions, and migrating all GitHub Actions to use uv commands. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Use
uvto manage the package development.Changes include:
tests/requirements.txtanddocs/requirements.txtby adevgroup inpyproject.toml(which is automatically installed byuv)requirements.txtCONTRIBUTING.rstto useuv runfor testing and building docsuv buildinstead ofpython -m buildinside the Github Action to publish the packageSummary by Sourcery
Switch to
uvfor dependency and task management by consolidating dev dependencies inpyproject.toml, removing legacy requirements files, and updating CI workflows and documentation to useuvcommands.Enhancements:
devdependency group inpyproject.tomlto centralize development requirementsrequirements.txt,docs/requirements.txt, andtests/requirements.txtfilesCI:
uvin all GitHub Actions workflows and replace pip-based steps withuv sync,uv run,uv build, anduvxcommandsDocumentation:
CONTRIBUTING.rstand documentation instructions to useuvcommands instead of pip