Skip to content

Conversation

@hagenw
Copy link
Member

@hagenw hagenw commented Jun 5, 2025

Add comments we forgot in #192 to indicate why we depend on onnxruntime.

Summary by Sourcery

Chores:

  • Annotate onnxruntime entries for Python 3.9 and 3.10+ with “for usage example with ASR” comments in pyproject.toml

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 5, 2025

Reviewer's Guide

Add explanatory comments to the onnxruntime dev dependencies in pyproject.toml to indicate they are needed for the ASR usage example.

File-Level Changes

Change Details Files
Add comments to clarify the purpose of onnxruntime dev dependencies
  • Appended “# for usage example with ASR” to the Python 3.9 onnxruntime entry
  • Appended “# for usage example with ASR” to the onnxruntime entry for Python ≥ 3.10
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@hagenw hagenw merged commit ded6357 into main Jun 5, 2025
19 checks passed
@hagenw hagenw deleted the add-comments branch June 5, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants