Include umd modules by default #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=======================================
Coverage 68.42% 68.42%
=======================================
Files 1 1
Lines 19 19
=======================================
Hits 13 13
Misses 6 6Continue to review full report at Codecov.
|
… from UMD But beware, this is still more than should be needed, and if wanting just this as UMD, prob should be part of application bundle, not separate vendor bundle as it's only one component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to include the umd by default. We use yarn, which doesn't perform all lifecycles on non-local (eg github) references. See yarnpkg/yarn#1671 (comment)). So our simplest approach would be to publish our fork, just for the umd modules, but we wouldn't need to if you could enable umd.
This might also have less surprises for newbies expecting to see umd resources whenbuilding - without needing to understand/notice nwb.config.js.
Thanks
Adam