Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception for posix not available #35

Closed
agentile opened this issue Sep 12, 2014 · 3 comments
Closed

Exception for posix not available #35

agentile opened this issue Sep 12, 2014 · 3 comments

Comments

@agentile
Copy link

Sounds like V2 packages intend to have some level of 5.3 support. In that area some builds don't have posix_isatty function available which occurs in Stdio::setPosix() since error reporting is turned off, when this happens it is hard to know without step debugging, as for example $stdio = $cliFactory->newStdio(); will just die with no output/php error. Perhaps a function_exists and Throwing of an exception may be warranted.

Not sure what the Aura take is on expected support is scenarios like this, just wanted you to be aware. Thanks!

@cordoval
Copy link
Contributor

is unfortunate, wish we could all move to nicer things 👍 for moving upwards on v2 aura packages

@harikt
Copy link
Member

harikt commented Sep 12, 2014

@agentile may be need a check http://php.net/manual/en/function.function-exists.php before

$this->posix = posix_isatty($this->resource);
.

@harikt
Copy link
Member

harikt commented Sep 12, 2014

@agentile pushed a PR #36 .

Thank you for reporting it. Hope that will help in the future.

Need to wait for Paul M Jones green signal.

@harikt harikt closed this as completed in 95edc0e Sep 21, 2014
pmjones pushed a commit that referenced this issue Sep 21, 2014
If posix_isatty function doesnot exists . Fixes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants