New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setters vs setter #115

Closed
harikt opened this Issue Feb 14, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@harikt
Member

harikt commented Feb 14, 2016

Hi Paul,

I noticed something for v3 .. It is currently named as setters and all previous versions were named as setter . Do you think it is good to have it as setter or trigger a warning so upgrade is much easier ?

Thank you

@pmjones

This comment has been minimized.

Show comment
Hide comment
@pmjones

pmjones Mar 11, 2016

Member

I'm trying to reduce the variability in the property names as much as I can. I think an upgrade guide could mention it explicitly.

Member

pmjones commented Mar 11, 2016

I'm trying to reduce the variability in the property names as much as I can. I think an upgrade guide could mention it explicitly.

@pmjones pmjones closed this Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment