Rearranging code to achieve full test coverage with the existing test suite #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably adding more tests may help to increase coverage. I like some of your ways, but the problem is then it happens to be nested blocks which seems not a good idea. @pmjones will look more into this and address the same. |
|
Nice. Thanks for the attention to detail! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the contributing guidelines, 100% test coverage should be maintained so this modifies the Reflector class in a manner that is only significant to the test suite to allow the existing test suite to obtain full coverage without any functional change.
Before
After
This just nixes a few lines of code and establishes 100% code coverage for the package.
Cheers, Thank you & Happy Holidays.