Add to autoload-dev for the tests classes to get loaded when #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra/di in require dev, so no need to explicitly require it in bootstrap as in auraphp/Aura.Router#72
| <directory>src/</directory> | ||
| </whitelist> | ||
| </filter> | ||
| </phpunit> |
There was a problem hiding this comment.
you should create a phpunit.xml.dist rather than a phpunit.xml (and ignore phpunit.xml in Git)
There was a problem hiding this comment.
So others can change their phpunit.xml and is local to the user ?
|
@pmjones thoughts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
aura/diin require dev, so no need to explicitly require it in bootstrap as in auraphp/Aura.Router#72