Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling autoresolve by default. #76

Closed

Conversation

brandonsavage
Copy link
Contributor

@harikt
Copy link
Member

harikt commented Dec 2, 2014

Adding a feedback from twitter https://twitter.com/donatj/status/539806052154220545

@harikt @brandonsavage Personally, I never liked auto resolution so off is good, removed is better.

@Grummfy
Copy link

Grummfy commented Dec 2, 2014

👍 for disabled by default but only on 2.2 to let people not too scary...

@cxj
Copy link
Contributor

cxj commented Dec 18, 2014

This seems like a sensible change to me.

@pmjones
Copy link
Member

pmjones commented Mar 15, 2015

I hate auto-resolve. Hate it. But to change the default flag from "auto-resolve" to "do not auto-resolve" is a BC break for existing code. Yes, users can change their code to turn auto-resolution back on, but the fact that they have to make the change at all indicates a break in previously-expected functionality. So until we do version 3, the hated auto-resolution has to stay on by default.

I say again, adding auto-resolution was the worst mistake I ever made in this package, maybe in any Aura package.

@pmjones pmjones closed this Mar 15, 2015
@harikt
Copy link
Member

harikt commented Mar 16, 2015

@pmjones I had a feeling earlier it was bad. But I don't think it was the worst one, for I still love that feature and I always remember the problem that it will bring ;) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants