Jk3us tests #27
Closed
Jk3us tests #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you @jk3us for the issues reported and further the PR with tests. Thank you. |
|
Scrutinize made B to C for the class Dispatcher :-/ . |
|
@pmjones could you look into this and merge if ok? |
|
FYI, I've been playing with your fixed branch, and it seems to be working ok. |
|
👍 . @pmjones merge ? |
|
@pmjones ping ? Else I will merge in 2 days :) ( warning ) . |
|
No, not yet -- I still want to review it and see if it can be incorporated against the other packages. Sorry for the delay. |
|
I was writing a mail to please consider looking at open PR . Call me arrogant. But I hate long waiting PR's :-/ . |
|
@pmjones ~ 3 months. Could you please find some time for this and make a release ?. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.