Removed Translator and various other improvements and corrections for version 2 of the component framework

[cordoval]

Q	A
Bug Fix?	yes
New Feature?	yes
BC Breaks?	expected
Deprecations?	translator related
Tests Pass?	yes
Fixed Tickets	none
License	Aura/MIT
Doc PR	no

Sent using Gush

Description

This PR was started after today's conversation on IRC, we synced with Hari and Paul to remove translator as a dependency from this component. There were some additional cleanups, moving to PSR-4, updating the readme, making the tests pass, correcting some typos on the tests, adding an autoload.php, creating a factory for the service instantiation and registry initialization and some other minor issues.

todo:

• update README.md with new structure

[cordoval]

@pmjones @harikt please run a first review, i still need to fix the Factory and also have a sort of registry i guess built inside the class

[cordoval]

@pmjones @harikt any early reviews?

[cordoval]

@pmjones @harikt ok that is it, thanks for your friendship 😊

[cordoval]

@harikt @pmjones could you please actually set scrutinizer for this repo? thanks

[pmjones]

Scrutinizer added just now per your request!

[cordoval]

thanks @pmjones

[cordoval]

@pmjones https://scrutinizer-ci.com/g/auraphp/Aura.Filter/ i see it however i cannot trigger it for develop-2 branch in which i am working

[cordoval]

there is a setting to trigger it for all builds in all branches

[pmjones]

updated to set develop-2 as the main branch

[cordoval]

@pmjones i think it sounds to me this is good to merge now. I see other components don't have common/config folder, should i remove it?

[harikt]

config folder is good. So don't remove it.

Thanks

[cordoval]

i will not, but i believe its place is elsewhere in another package

[cordoval]

@harikt @pmjones ok Paul said he will review tomorrow. Other fixes or improvements can come later.

[harikt]

One thing I like in v2 is usage of

$email = new Aura\Filter\Email('email@example.com');
$email->isValid();

like interface. I am not sure whether this is possible currently.

But just a wishlist . The idea is usage of filters in DDD as Mathias Verras mentioned in some slides.

[cordoval]

Please open a ticket with that wish maybe we can implement but it is not related to this PR. 😊 Is actually a very good idea, to go strong in DDD with aura libraries.

[harikt]

hhvm not working?

[cordoval]

i just don't think we should test against something that fails and that is not fully working, we either remove it or remove the allow_failtures cc @pmjones

[harikt]

Hey @cordoval could you add a branch alias?

"branch-alias": {
    "dev-develop-2": "2.0.x-dev"
}

See https://github.com/auraphp/Aura.Web/blob/develop-2/composer.json#L33-L35

[cordoval]

@pmjones please review and merge. What comes after this? What other component needs help? Or should we move cordoval/bc-analyzer into auraphp? so we can pound on it?

[harikt]

@cordoval could you have a look into the https://github.com/auraphp/Aura.Filter/issues?state=open #31 , #32, #34 , , #43

And your thoughts how to improve?

[cordoval]

ok i can but let's close this chapter PR please

[harikt]

Sure. Let Paul review things. Please give him sometime.

Aura.Session v2 need some help / improvements. I don't really know what all
are planned though / good.

[pmjones]

I'll take this as-is and review later. Many thanks for your work, gentlemen.