Removed Translator and various other improvements and corrections for version 2 of the component framework #40
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,4 @@ | ||
| /tests/tmp | ||
| /vendor | ||
| /build | ||
| /composer.lock | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| tools: | ||
| php_code_coverage: | ||
| test_command: "phpunit -c tests/" | ||
| filter: | ||
| paths: ["src/*"] | ||
| php_sim: | ||
| enabled: true | ||
| filter: | ||
| paths: ["src/*"] | ||
| php_mess_detector: | ||
| enabled: true | ||
| filter: | ||
| paths: ["src/*"] | ||
| php_pdepend: | ||
| enabled: true | ||
| filter: | ||
| paths: ["src/*"] | ||
| php_analyzer: | ||
| enabled: true | ||
| filter: | ||
| paths: ["src/*"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,8 @@ language: php | |
| php: | ||
| - 5.4 | ||
| - 5.5 | ||
| before_script: | ||
|
There was a problem hiding this comment. i just don't think we should test against something that fails and that is not fully working, we either remove it or remove the allow_failtures cc @pmjones |
||
| - cd tests | ||
| script: phpunit | ||
| notifications: | ||
| irc: "irc.freenode.org#auraphp" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question, I tested this and it is working as expected. But is there any difference with
/in front and without.See
tests/tmpand/tests/tmp. The/makes me think like root of Linux, but now I am getting to root of git.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the / up front basically will ignore only /file so the rood project file named
fileand not nested instances which is more specific