Add more ip validation

[BallisticPain]

Adds validation for v4 and v6 through 'ip'
Adds validation for v6 through 'ipv6'
Updates validation for v4 by using filter_var instead of ip2long

[harikt]

What about changing it to something like

if (filter_var($value, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4 | FILTER_FLAG_IPV6)) {
    return true;
}
return false;

Is there any reason you didn't do that ? Just my suggestion, you should hear what @pmjones thinks about this before doing the change.

[BallisticPain]

@harikt,

Good question. I was just attempting to be explicit. I don't imagine there is an IP Address that could return and be considered a false, but the way I wrote it ensures that cannot happen.

Thoughts?
Jarvis

[auroraeosrose]

filter_var is an odd duck - like strcmp 0 might be a perfectly legal return and PHP does... odd things with strings that start with 0
it's generally better to do an exact === check, since that is actual failure for the filter, not just a value PHP would consider "empty " as the return

[harikt]

Thank you @auroraeosrose for clarifying.

@BallisticPain all is good .

Thank you.

[cxj]

I read through the code. This looks like a good enhancement.

[pmjones]

Thanks @BallisticPain for submitting, and everyone else for reviewing. :-)