Fixes issue-4 when PATH_INFO was passed #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with this fix is that it fails on Apache when you pass a query string. (The query string is part of the URI.) |
|
Hm, we can modify it so that we run parse_url() against REQUEST_URI to extract only the path. |
pmjones
pushed a commit
that referenced
this pull request
Jul 4, 2012
Fixes issue-4 when PATH_INFO was passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues running tests.
Have 10 failures for rmdir . I feel its permission issues .
I was running from
Anyway this not regarding running tests .
Its a PR for #4
Changing
PATH_INFOtoREQUEST_URIfixes when the server is started via php command line. Also PATH_INFO only available for apache , so ngix will also have issues ?