Fix data reset from render due to getting value set from the controller ...

[harikt]

As we are already setting the data from controller as

$this->view->setInnerData($data);
$this->data = $some_other_data;

We are missing to merge these both data from the Aura\Framework\Web\AbstractPage::render()

[harikt]

Or we want to add the values to setInnerData() in view than resetting it .

[harikt]

@pmjones not a good fix ?

[harikt]

This is a priority fix . I wonder why you didn't merged this . Probably working on a different rendering strategy ?

[harikt]

Also this is related with issue #6 which I closed 4 days back. Have a look into it .

[pmjones]

Help me to understand what the point is. What bug does this fix?

[harikt]

@pmjones sure I will try . Have a look into an example https://github.com/harikt/Hari.Blog/blob/master/src/Hari/Blog/Web/Post/Page.php#L19

public function actionAdd()
{
    $stdObject = new \stdclass();
    $stdObject->name = "Hari K T";
    $data = array();
    $data['authors'] = array_fill(0, 10, $stdObject);
    $this->view->setInnerData($data);
    $this->view->setInnerView('add');
}

And now in https://github.com/auraphp/Aura.Framework/blob/master/src/Aura/Framework/Web/AbstractPage.php render() https://github.com/auraphp/Aura.Framework/blob/master/src/Aura/Framework/Web/AbstractPage.php#L215

         $data = (array) $this->getData();
         $this->view->setInnerData($data);

Where getData() is at https://github.com/auraphp/Aura.Web/blob/master/src/Aura/Web/AbstractPage.php#L138

Which is set at constructor https://github.com/auraphp/Aura.Web/blob/master/src/Aura/Web/AbstractPage.php#L93

So the inner_data is not merged.

Or in the action we need to set to $this->data rather than $this->view->setInnerData() . Hope that's clear .

[harikt]

Closing for we don't set data this way .

$this->view->setInnerData($data);

But via

$this->data = $data