Return empty string instead of null in AbstractList::__toString

[Avaq]

In PHP, __toString must return a string, or an error is raised.

[harikt]

The build fails, I assume it can be returned null than empty string will help.

[harikt]

@Avaq see https://travis-ci.org/auraphp/Aura.Html/jobs/38716823#L41

[Avaq]

Ah there is a unit-test testing for specifically null. Very odd because when null is returned from __toString on my PHP version, I get:

Catchable fatal error: Method Aura\Html\Helper\Ul::__toString() must return a string value in ...

[Avaq]

Shall I modify the unit-test or is this intended behaviour?

[harikt]

You should ping @pmjones then.

Hari K T

You can ring me : +91 9388 75 8821

http://harikt.com , https://github.com/auraphp ,
http://www.linkedin.com/in/harikt , http://www.xing.com/profile/Hari_KT

Skype : kthari85
Twitter : harikt

On Wed, Oct 22, 2014 at 8:45 PM, Aldwin Vlasblom notifications@github.com
wrote:

Shall I modify the unit-test or is this intended behaviour?

—
Reply to this email directly or view it on GitHub
#25 (comment).

[Avaq]

The problem is as follows: When PHP uses the __toString() method to cast an object into a string, it forces the method to return a string, as demonstrated by this test. The unit-tests never test for this, because they always call $ol()->__toString() directly.

I will modify the unit-test accordingly and push to this branch.

[harikt]

@Avaq may be branch out from this and send a different PR .

[harikt]

I am ok with this. Assuming no one tried to compare the return of __toString to null as in unit tests ;-) .

[Avaq]

People who expect the return value of __toString to equal null are asking for their code to break anyway. 😈

[Avaq]

✅