ICU and Intl Version Checks #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,6 +21,9 @@ protected function newFormatter() | |||
| */ | |||
| public function testFormat_plural() | |||
| { | |||
| if (version_compare(INTL_ICU_VERSION, '4.8') < 0) { | |||
| $this->markTestSkipped('Skip for ICU 4.8+'); | |||
There was a problem hiding this comment.
The sentence will be Skip for ICU < 4.8 not for 4.8+ no? For the one below also .
|
@harikt It depends on how you interpret it ;) |
|
@mapthegod ok . But for me I read it as it will skip for |
|
@harikt Well i see your point. I will change the PR accordingly. |
|
No . Wait . Ask @pmjones . For if the rest of the tests are like that , it needs some clarification . |
…h ICU Version lower than 4.8; Skip all IntlFormatter tests if the intl extension is not loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making ICU Version 4.8+ a requirement for using IntlFormatter.
If ICU < 4.8 a IcuVersionTooLow Exception is thrown on instantiating IntlFormatter.
Skip tests if the intl extension is not loaded.