Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Functionality to delete Entities #9

Merged
merged 3 commits into from May 7, 2013

Conversation

mapthegod
Copy link

deleteEntity()

Added

Aura\Marshal\Type\GenericType->deleteEntity($identity_value)

The Function takes the identity_value of the Entity to be deleted as parameter and deletes it from all indicies.

getDeletedEntitiesIds()

Added

Aura\Marshal\Type\GenericType->getDeletedEntitiesIds()

The function takes no arguments and returns an array of identity_values of Entities deleted using deleteEntity()

Tests

Added several test for the Deletion Functionality

@harikt
Copy link
Member

harikt commented Jan 2, 2013

May I know why you need delete Entities?

@mapthegod
Copy link
Author

@harikt I'm working on a DataProvider which automatically handles saving new, updated and now also deleted Entities to a backend. And as I need to have a delete functionality on some of the Entites, I wrote these little functions.
I just decided to open a pull request to share it with you, and discuss whether it should be merged into the main repo or not.

@mapthegod
Copy link
Author

We may also discuss this in the IRC, if you wish

@harikt
Copy link
Member

harikt commented Jan 2, 2013

@mapthegod Thank you for the quick response. I was just curious to know, that's all. Please wait for @pmjones to look into it further . I am not that much into Marshal :) .

@pmjones pmjones merged commit d9a1d57 into auraphp:develop May 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants