Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new composer installed.json format #14

Merged
merged 3 commits into from Aug 1, 2021

Conversation

sixcare
Copy link
Contributor

@sixcare sixcare commented Jan 27, 2021

Fixes issue #13

@pmjones
Copy link
Member

pmjones commented Jan 28, 2021

Hey @sixcare it looks like the Travis tests fail -- any thoughts on how to remedy?

@sixcare
Copy link
Contributor Author

sixcare commented Jan 28, 2021

Hey @sixcare it looks like the Travis tests fail -- any thoughts on how to remedy?

I'm not quite familiar with the Travis test.

From what I can see the PHP7 test failed because of this:

This version of PHPUnit is supported on PHP 7.1 and PHP 7.2.
You are using PHP 7.0.33 (/home/travis/.phpenv/versions/7.0.33/bin/php).
The command "phpunit --coverage-clover=coverage.clover" exited with 1.

the PHP5.6 test completed

OK, but incomplete, skipped, or risky tests!
Tests: 9, Assertions: 9, Skipped: 1.

If you're on IRC I'd be happy to chat with you about this Issue and pull-request @pmjones

@harikt
Copy link
Member

harikt commented Jul 13, 2021

Hey @sixcare , @kenjis has merged your PR on #15 . So I guess this should have been fixed.

In case if you find any issues we can reopen it. Thanks once again for the PR.

@harikt harikt closed this Jul 13, 2021
@kumamidori kumamidori mentioned this pull request Jul 29, 2021
@harikt harikt reopened this Aug 1, 2021
@harikt harikt merged commit d51e2bc into auraphp:2.x Aug 1, 2021
@harikt
Copy link
Member

harikt commented Aug 1, 2021

Fixing this in 2.x branch. Thank you @sixcare .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants