Add getMatchedRouter() function to Router object. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Router object will now remember the route it matched so it can be fetched again without repeating the whole matching process (which can be costly if there are a lot of routes). Also added lots of tests for the new functionality.
|
Well that's embarrassing. I mislabelled the commit "getMatchedRouter()" when it should have been "getMatchedRoute()". My understanding is that to fix this, I'd have to close this pull request, update my branch locally, do a force push to my fork, and then submit another pull request. Is that correct? |
|
You can just make a commit making the necessary changes. |
|
The problem is in the commit message, not the code changes. |
|
aah then leave it . |
pmjones
pushed a commit
that referenced
this pull request
Apr 3, 2014
Add getMatchedRoute() function to Router object.
|
ha you merged it . |
| * @var Route | ||
| * | ||
| */ | ||
| protected $matchedRoute = null; |
There was a problem hiding this comment.
Hey @djmattyg007 I had a discussion with @pmjones on irc.
He mentioned you to join some time in irc .
one of the thing mentioned is regarding the name matchedRoute to matched_route .
We will fix ourselves.
Thank you .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Router object will now remember the route it matched so it can be
fetched again without repeating the whole matching process (which can be
costly if there are a lot of routes).
Also added lots of tests for the new functionality.
This is the pull request for issue #37.