New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FakeSessionHandler::write() (fixes PHP7 tests) #35

Merged
merged 1 commit into from Feb 8, 2015

Conversation

Projects
None yet
2 participants
@iansltx
Contributor

iansltx commented Feb 6, 2015

The ‘write’ session handler should return a boolean, but this isn’t
enforced prior to PHP 7. So the test (rather than the session) breaks
under PHP 7. Until now…

Ian Littman
Return result for FakeSessionHandler::write()
The ‘write’ session handler should return a boolean, but this isn’t
enforced prior to PHP 7. So the test (rather than the session) breaks
under PHP 7. Until now…

pmjones added a commit that referenced this pull request Feb 8, 2015

Merge pull request #35 from iansltx/php7-compat
Fix FakeSessionHandler::write() (fixes PHP7 tests)

@pmjones pmjones merged commit 08df0fc into auraphp:develop-2 Feb 8, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci The Travis CI build passed
Details
@pmjones

This comment has been minimized.

Member

pmjones commented Feb 8, 2015

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment