Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite-specific query objects #52

Merged
merged 1 commit into from Sep 11, 2013
Merged

Conversation

MAXakaWIZARD
Copy link
Contributor

Also get rid of some duplication via creating LimitTrait, OffsetTrait and OrderByTrait

@MAXakaWIZARD
Copy link
Contributor Author

Link to SQLite SQL syntax documentation: http://www.sqlite.org/lang.html

@harikt
Copy link
Member

harikt commented Sep 11, 2013

Nice and Thank you. It seems good to me.

@harikt
Copy link
Member

harikt commented Sep 11, 2013

and we are about to release the package. @pmjones What do you feel on this?

@harikt
Copy link
Member

harikt commented Sep 11, 2013

Just a different note @MAXakaWIZARD . Your site looks nice . Also do remember to checkout to new branch and commit, else you will get into trouble 👎 .

@MAXakaWIZARD
Copy link
Contributor Author

Thanks! What do you mean "checkout to new branch and commit, else you will get into trouble". I regularly do pull upstream.

@MAXakaWIZARD
Copy link
Contributor Author

About release. I think we should wait until I implement PgSql query objects...

@harikt
Copy link
Member

harikt commented Sep 11, 2013

@MAXakaWIZARD what I meant is when you commit to develop of your branch, and at some point the commit is not accepted, you may get into merge conflicts or the commits will be already there when you send a new PR.

That is to get rid of these we make a new branch from develop and later send a PR on that merging with upstream.

I wrote something how I worked, may be there can be a better approach though, you can read at http://auraphp.com/blog/2012/07/13/contributing-to-aura-project/

Thank you for the contributions.

@harikt
Copy link
Member

harikt commented Sep 11, 2013

Do checkout subpackages of v2 ( https://github.com/auraphp/Aura.Sql/tree/subpackages ) . So we can have it in early stages itself.

Thanks

@MAXakaWIZARD
Copy link
Contributor Author

Ok, I see. Thanks for good points!

@pmjones
Copy link
Member

pmjones commented Sep 11, 2013

Sweet!

pmjones pushed a commit that referenced this pull request Sep 11, 2013
Sqlite-specific query objects
@pmjones pmjones merged commit a2bad69 into auraphp:develop Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants