New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlite-specific query objects #52
Conversation
…ng LimitTrait, OffsetTrait and OrderByTrait
|
Link to SQLite SQL syntax documentation: http://www.sqlite.org/lang.html |
|
Nice and Thank you. It seems good to me. |
|
and we are about to release the package. @pmjones What do you feel on this? |
|
Just a different note @MAXakaWIZARD . Your site looks nice . Also do remember to checkout to new branch and commit, else you will get into trouble 👎 . |
|
Thanks! What do you mean "checkout to new branch and commit, else you will get into trouble". I regularly do pull upstream. |
|
About release. I think we should wait until I implement PgSql query objects... |
|
@MAXakaWIZARD what I meant is when you commit to develop of your branch, and at some point the commit is not accepted, you may get into merge conflicts or the commits will be already there when you send a new PR. That is to get rid of these we make a new branch from develop and later send a PR on that merging with upstream. I wrote something how I worked, may be there can be a better approach though, you can read at http://auraphp.com/blog/2012/07/13/contributing-to-aura-project/ Thank you for the contributions. |
|
Do checkout subpackages of v2 ( https://github.com/auraphp/Aura.Sql/tree/subpackages ) . So we can have it in early stages itself. Thanks |
|
Ok, I see. Thanks for good points! |
|
Sweet! |
Sqlite-specific query objects
Also get rid of some duplication via creating LimitTrait, OffsetTrait and OrderByTrait