Correctly handle zero-indexed placeholder arrays on execute #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if y'all want me to close this PR and re-open with just the second commit; the first one doesn't solve the problem. |
|
@iansltx I am seeing test also. or am I missing something? This looks good to me. Paul will verify and merge. Be patient 👍 . Thank you. |
|
When I made the PR originally I only had the first commit, which didn't include a test. The test is there now 😁 |
|
Thanks for the test. This was an unexpected behavior from PDO; glad to see you caught it. |
pmjones
pushed a commit
that referenced
this pull request
Jun 26, 2014
Correctly handle zero-indexed placeholder arrays on execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No test yet; opening the PR to get feedback/test-running. Fixes #75.