Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty elements in $urlFactoryInstance->path #9

Closed
calvinfroedge opened this issue Nov 6, 2012 · 3 comments
Closed

Empty elements in $urlFactoryInstance->path #9

calvinfroedge opened this issue Nov 6, 2012 · 3 comments

Comments

@calvinfroedge
Copy link

Uri\Url\Factory instance for site.dev/foo/bar yields the following path property:

array(4) { [0]=> string(0) "" [1]=> string(3) "foo" [2]=> string(3) "bar" [3]=> string(0) "" }

Is there a reason for the two empty array elements? My expectation would be to receive this:

array(4) { [0]=> string(3) "foo" [1]=> string(3) "bar" }

@calvinfroedge
Copy link
Author

Btw if you agree with this I can make the change...

@harikt
Copy link
Member

harikt commented Nov 6, 2012

@calvinfroedge I feel you are correct. But I will wait for @pmjones . If its an easy one you can work on creating a branch from develop and sending a PR to develop branch itself .

Thank you for the bugs and welcome tests 👍 .

pmjones pushed a commit that referenced this issue Nov 23, 2012
@pmjones
Copy link
Member

pmjones commented Nov 23, 2012

This should be fixed. Let me know if it is not.

@pmjones pmjones closed this as completed Nov 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants