Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autoload-dev so users can use Fakeresponse sender when needed on tes... #46

Merged
merged 1 commit into from Jan 19, 2015
Merged

Add autoload-dev so users can use Fakeresponse sender when needed on tes... #46

merged 1 commit into from Jan 19, 2015

Conversation

harikt
Copy link
Member

@harikt harikt commented Nov 18, 2014

...ting

@harikt
Copy link
Member Author

harikt commented Nov 18, 2014

@pmjones what are your thoughts on adding to autoload-dev ?

Can I merge this ?

@mbrevda
Copy link

mbrevda commented Dec 7, 2014

@pmjones +1

@mbrevda mbrevda mentioned this pull request Dec 24, 2014
Closed
@pmjones
Copy link
Member

pmjones commented Jan 19, 2015

Overcoming my initial resistance to this. ;-)

pmjones pushed a commit that referenced this pull request Jan 19, 2015
Merge pull request #46 from harikt/auto-dev
6b79ef5 
Add autoload-dev so FakeResponse is available for tests
@pmjones pmjones merged commit 6b79ef5 into auraphp:develop-2 Jan 19, 2015
@mbrevda
Copy link

mbrevda commented Jan 19, 2015

👏

@harikt
Copy link
Member Author

harikt commented Jan 20, 2015

I was thinking the other day, the FakeResponse, FakeSessionHandler etc should move to src, and promote using it for testing. Else people will have hard time to figure how to test .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harikt @mbrevda @pmjones