Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow _env to check getenv as well as $_ENV #5

Closed
wants to merge 1 commit into from

Conversation

garoevans
Copy link

No description provided.

@pmjones
Copy link
Member

pmjones commented Jan 27, 2014

@vlucas pointed this out to me at a recent conference: https://github.com/vlucas/phpdotenv

Including that at the project level looks like it might solve our woes here.

@harikt
Copy link
Member

harikt commented Jan 28, 2014

good @pmjones 👍

@garoevans
Copy link
Author

Looks nice and lightweight. Fixes my problem :)

@pmjones
Copy link
Member

pmjones commented Jan 29, 2014

OK, so, I'm going to decline this pull request, but not because it's a bad idea or badly implemented. I have made some changes to Web_Kernel that should make this PR unnecessary. You should be able to add 'vlucas/dotenv' to your project composer file, update the projects, and then use Dotenv::load() in your _env.php file. This has the benefit of allowing any type of _env.php logic you want, Dotenv or no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants