fix(router): properly handle false in conditional router hooks #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 88.37% 88.47% +0.10%
==========================================
Files 260 260
Lines 22847 22842 -5
Branches 5300 5296 -4
==========================================
+ Hits 20190 20209 +19
+ Misses 2657 2633 -24 ☔ View full report in Codecov by Sentry. |
bigopon
reviewed
Feb 13, 2024
bigopon
force-pushed
the
jwx-router-hooks-issue
branch
from
461125b
to
cda7d5c
Compare
AureliaEffect
pushed a commit
that referenced
this pull request
Mar 2, 2024
2.0.0-beta.12 (2024-03-02) **BREAKING CHANGE:** * **enhance:** call app tasks with `.enhance` API, return app root instead of controller (#1916) ([4d522b2](4d522b2)) * **au-compose:** always create host for non custom element composition (#1906) ([8a28e0a](8a28e0a)) **Features:** * **au-compose:** ability to compose string as element name (#1913) ([06aa113](06aa113)) **Bug Fixes:** * **router:** prevent multiple navigation at the same time (#1895) ([deed11e](deed11e)) * **router:** properly handle false in conditional router hooks (#1900) ([a671463](a671463)) * **di:** dont jit register resources ([8ffde34](8ffde34)) * **di:** new instance resolver (#1909) ([efe208c](efe208c)) * **runtime:** tweak typings of injectable token ([89f76eb](89f76eb)) **Refactorings:** * **runtime:** delay overriding array prototypes (#1914) ([d8be144](d8be144)) * **router:** use resolve ([89f76eb](89f76eb)) * **runtime:** better type inferrence for injectable token ([89f76eb](89f76eb)) * **di:** simplify container has, cleanup router ([89f76eb](89f76eb)) **Docs:** * **docs:** add JS examples using resolve for IHttpClient (#1907) ([d57c1f1](d57c1f1)) * **doc:** remove define hook from documentation (#1903) ([f684141](f684141))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR fixes issues that could occur when several denying async router hooks were applied to the same component.
📑 Test Plan