refactor(compiler): simplify definition creation #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1950 +/- ##
==========================================
- Coverage 88.47% 88.45% -0.02%
==========================================
Files 264 264
Lines 22770 22770
Branches 5284 5285 +1
==========================================
- Hits 20146 20142 -4
- Misses 2624 2628 +4 ☔ View full report in Codecov by Sentry. |
AureliaEffect
pushed a commit
that referenced
this pull request
May 3, 2024
2.0.0-beta.16 (2024-05-03) **Bug Fixes:** * **au-slot:** ensure passthrough slot get the right host value (#1959) ([f266ddd](f266ddd)) * **rendering:** correctly handle compilation cache (#1955) ([c11491b](c11491b)) **Refactorings:** * **router-lite:** avoided duplicate CE defn reg to same container (#1956) ([6578e54](6578e54)) * **compiler:** extract template compiler into own package (#1954) ([ad7ae1e](ad7ae1e)) * **compiler:** simplify definition creation (#1950) ([bb0fcab](bb0fcab)) * **observers:** use static blocks, group related code ([ca22bc8](ca22bc8)) * **runtime:** move scope to runtime html (#1945) ([bca0290](bca0290))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
To prepare for the extraction of template compiler extraction, the direct usage of resources APIs first need to be simplified. Instead of using full element definition, only use partial. It turns out to be a pretty good change, template compiler emits just enough information about what it sees in the template.
cc @Sayan751 @fkleuver