refactor: extract template compiler into own package #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/extract-compiler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
+ Coverage 88.46% 88.64% +0.17%
==========================================
Files 264 272 +8
Lines 22770 22821 +51
Branches 5285 5290 +5
==========================================
+ Hits 20144 20230 +86
+ Misses 2626 2591 -35 ☔ View full report in Codecov by Sentry. |
|
Nice work @bigopon! Does this trigger a change in the convention package? For the |
It does, I forgot about this. Maybe we can keep things as is by reexporting |
AureliaEffect
pushed a commit
that referenced
this pull request
May 3, 2024
2.0.0-beta.16 (2024-05-03) **Bug Fixes:** * **au-slot:** ensure passthrough slot get the right host value (#1959) ([f266ddd](f266ddd)) * **rendering:** correctly handle compilation cache (#1955) ([c11491b](c11491b)) **Refactorings:** * **router-lite:** avoided duplicate CE defn reg to same container (#1956) ([6578e54](6578e54)) * **compiler:** extract template compiler into own package (#1954) ([ad7ae1e](ad7ae1e)) * **compiler:** simplify definition creation (#1950) ([bb0fcab](bb0fcab)) * **observers:** use static blocks, group related code ([ca22bc8](ca22bc8)) * **runtime:** move scope to runtime html (#1945) ([bca0290](bca0290))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Currently the template compiler and compilation related infra are part of the runtime html, but it doesn't need to be, splitting this out into its own separate package to promote a reusable bit for build time pre compilation.
The following exports will be moved to the new package
@aurelia/template-compilerfrom@aurelia/runtime-htmlApplications importing the above from the
aureliapackage won't need to adjust their code, since it'll be the same from within theaureliapackage.Side note: this also allows me to have a clearer look of what a hello world Aurelia app weights like, it's about ~100KB (minified) so this'll be our achievable target with build time pre-compilation, after probably quite some amount of work. With moderate amount of work, its about ~140KB (minified), which is quite acceptable for most apps.
🎫 Issues
Resolve #1746
cc @Sayan751 @fkleuver