-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract template compiler into own package #1954
Conversation
…/extract-compiler
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
+ Coverage 88.46% 88.64% +0.17%
==========================================
Files 264 272 +8
Lines 22770 22821 +51
Branches 5285 5290 +5
==========================================
+ Hits 20144 20230 +86
+ Misses 2626 2591 -35 ☔ View full report in Codecov by Sentry. |
Nice work @bigopon! Does this trigger a change in the convention package? For the |
It does, I forgot about this. Maybe we can keep things as is by reexporting |
2.0.0-beta.16 (2024-05-03) **Bug Fixes:** * **au-slot:** ensure passthrough slot get the right host value (#1959) ([f266ddd](f266ddd)) * **rendering:** correctly handle compilation cache (#1955) ([c11491b](c11491b)) **Refactorings:** * **router-lite:** avoided duplicate CE defn reg to same container (#1956) ([6578e54](6578e54)) * **compiler:** extract template compiler into own package (#1954) ([ad7ae1e](ad7ae1e)) * **compiler:** simplify definition creation (#1950) ([bb0fcab](bb0fcab)) * **observers:** use static blocks, group related code ([ca22bc8](ca22bc8)) * **runtime:** move scope to runtime html (#1945) ([bca0290](bca0290))
📖 Description
Currently the template compiler and compilation related infra are part of the runtime html, but it doesn't need to be, splitting this out into its own separate package to promote a reusable bit for build time pre compilation.
The following exports will be moved to the new package
@aurelia/template-compiler
from@aurelia/runtime-html
Applications importing the above from the
aurelia
package won't need to adjust their code, since it'll be the same from within theaurelia
package.Side note: this also allows me to have a clearer look of what a hello world Aurelia app weights like, it's about ~100KB (minified) so this'll be our achievable target with build time pre-compilation, after probably quite some amount of work. With moderate amount of work, its about ~140KB (minified), which is quite acceptable for most apps.
🎫 Issues
Resolve #1746
cc @Sayan751 @fkleuver