refactor: linting fixes

[BBosman]

Pull Request

📖 Description

Miscellaneous linting fixes.

🎫 Issues

Related to #249.

👩‍💻 Reviewer Notes

Mostly adding readonly.

📑 Test Plan

Trust CircleCI

⏭ Next Steps

See #249.

[codeclimate]

Code Climate has analyzed commit a9e26ad and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 87.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.4% (0.0% change).

View more on Code Climate.

[codecov]

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is 90.47%.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files         119      119           
  Lines       10496    10496           
  Branches     1819     1818    -1     
=======================================
  Hits         9433     9433           
  Misses       1063     1063

Impacted Files	Coverage Δ
packages/router/src/viewport.ts	88.23% <ø> (ø)	⬆️
packages/runtime-html/src/binding/listener.ts	80.64% <ø> (ø)	⬆️
packages/router/src/router.ts	81.38% <ø> (ø)	⬆️
packages/jit/src/resource-model.ts	97.87% <ø> (ø)	⬆️
.../src/resources/binding-behaviors/update-trigger.ts	26.08% <ø> (ø)	⬆️
...kages/runtime/src/observation/computed-observer.ts	33.54% <ø> (ø)	⬆️
packages/runtime/src/observation/dirty-checker.ts	28.3% <ø> (ø)	⬆️
packages/runtime/src/binding/call.ts	92.72% <ø> (ø)	⬆️
packages/runtime/src/observation/self-observer.ts	95.65% <ø> (ø)	⬆️
packages/runtime-html/src/html-renderer.ts	100% <ø> (ø)	⬆️
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ad3cf...a9e26ad. Read the comment docs.

[codecov]

Codecov Report

Merging #358 into master will increase coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   90.53%   90.54%   +0.01%     
==========================================
  Files         115      115              
  Lines       10258    10269      +11     
  Branches     1774     1774              
==========================================
+ Hits         9287     9298      +11     
  Misses        971      971

Impacted Files	Coverage Δ
packages/runtime-html/src/binding/listener.ts	80.64% <ø> (ø)	⬆️
packages/jit/src/resource-model.ts	97.87% <ø> (ø)	⬆️
.../src/resources/binding-behaviors/update-trigger.ts	26.08% <ø> (ø)	⬆️
...kages/runtime/src/observation/computed-observer.ts	33.54% <ø> (ø)	⬆️
packages/runtime/src/observation/dirty-checker.ts	28.3% <ø> (ø)	⬆️
packages/runtime/src/binding/call.ts	92.72% <ø> (ø)	⬆️
packages/runtime/src/observation/self-observer.ts	95.65% <ø> (ø)	⬆️
packages/runtime-html/src/html-renderer.ts	100% <ø> (ø)	⬆️
...ckages/runtime/src/observation/observer-locator.ts	99.13% <ø> (ø)	⬆️
packages/runtime/src/definitions.ts	92.59% <ø> (ø)	⬆️
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef295f...7bacb59. Read the comment docs.

[fkleuver]

Nice :) I also like the change in brace placement on switch/case, it makes more sense this way.

LGTM @EisenbergEffect

[BBosman]

Rebased on current master and added three missing semicolons in runtime-pixi.

[EisenbergEffect]

@BBosman Can you resolve conflicts again? We had a big router PR merge today that caused a couple of issues.

[BBosman]

@EisenbergEffect Rebased. I'll do the other one once this one is merged as that'll create more/new merge conflicts there. 😄

[EisenbergEffect]

Great work again @BBosman ! Thanks for keeping us up to quality.