New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DirtyCheckProperty in d.ts #648

Closed
gama410 opened this Issue Nov 23, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@gama410

gama410 commented Nov 23, 2017

I'm submitting a bug report

  • Library Version:
    1.2.2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    6.11.0

  • NPM Version:
    5.2.0
  • JSPM OR Webpack AND Version
    webpack ??
  • Browser:
    Chrome XX | Firefox XX

  • Language:
    TypeScript 2.6.1

Current behavior:
I'm trying to import DirtyCheckProperty from aurelia-binding using the following line:
import {DirtyCheckProperty} from 'aurelia-binding';

but tsc transpilation throws the following error:
Error: src\main.ts(9,9): error TS2305: Module '"..../node_modules/aurelia-binding/dist/aurelia-binding"' has no exported member 'DirtyCheckProperty'.

Although it works well at runtime (it is just a typescript error because it can't find it in the d.ts but the feature is available in aurelia-binding.js)

Expected/desired behavior:

  • What is the expected behavior?

I expected to be able to import this but it doesn't appear in aurelia-binding.d.ts anymore (it was before).

  • What is the motivation / use case for changing the behavior?
    I'm not sure a change is necessary : Maybe this feature is expected to be removed or accessible from elsewhere? Otherwise, the d.ts would probably need to be regenerated to include this class...
@gama410

This comment has been minimized.

Show comment
Hide comment
@gama410

gama410 commented Nov 29, 2017

@jdanyow jdanyow closed this in 2c29855 Dec 3, 2017

@jdanyow

This comment has been minimized.

Show comment
Hide comment
@jdanyow

jdanyow Dec 3, 2017

Member

@gama410 this will be available in the next release of aurelia-binding

Member

jdanyow commented Dec 3, 2017

@gama410 this will be available in the next release of aurelia-binding

@gama410

This comment has been minimized.

Show comment
Hide comment
@gama410

gama410 Dec 3, 2017

great! Thanks for the fix!

gama410 commented Dec 3, 2017

great! Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment