New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not bundling properly when adding a shim for CSS files in JSPM #168

Open
justindra opened this Issue Oct 30, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@justindra
Copy link

justindra commented Oct 30, 2017

I'm submitting a bug report

  • Library Version:
    0.6.1

Please tell us about your environment:

  • Operating System:
    Linux (Arch)

  • Node Version:
    6.11.1

  • NPM Version:
    3.10.10

  • JSPM OR Webpack AND Version
    JSPM 0.16.53

  • Browser:
    all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView

  • Language:
    ESNext

Current behavior:
Adding a shim to package.json under jspm overrides for flatpickr

     "npm:flatpickr@4.0.6": {
        "registry": "jspm",
        "main": "dist/flatpickr",
        "dependencies": {
          "css": "*"
        },
        "shim": {
          "dist/flatpickr": [
            "./flatpickr.css!"
          ]
        }
      }

When I add this in, then I am receiving an error on runtime of Cannot read property 'get' of undefined. Upon further inspection this is because System.registry is undefined. It looks like there is a mismatch between the bundler choosing the latest SystemJS Syntax and the actual SystemJs being loaded in.

Weirdly only happens when I add that shim for CSS. If I remove the override, all is well and there seems to be no problems at all.

  • What is the expected behavior?
    For it to bundle properly and to be able to load on runtime.
@justindra

This comment has been minimized.

Copy link

justindra commented Oct 30, 2017

Downgrading to Aurelia Bundler 0.5.0 fixes the issue for the time being.

@m-gallesio

This comment has been minimized.

Copy link

m-gallesio commented Jan 8, 2019

This also happens if SystemJS's plugin-css is installed as of 0.7.0. Again, 0.5.0 works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment