Permalink
Browse files

fix(webpack): use webpack4 hook that replaced deprecated plugin api

Thanks @oising for the fix. @jods4 recommended using a meaningful tap name.

closes #923
  • Loading branch information...
huochunpeng committed Oct 14, 2018
1 parent 9ebe10a commit 8b5d732887f5b45e12b2219992435e67ea55e8b1
Showing with 2 additions and 2 deletions.
  1. +1 −1 lib/resources/tasks/build-webpack.js
  2. +1 −1 lib/resources/tasks/build-webpack.ts
@@ -23,7 +23,7 @@ function buildWebpack(done) {
compiler.watch({}, onBuild);
} else {
compiler.run(onBuild);
compiler.plugin('done', () => done());
compiler.hooks.done.tap('AureliaCLI', done);
}
}
@@ -23,7 +23,7 @@ function buildWebpack(done) {
compiler.watch({}, onBuild);
} else {
compiler.run(onBuild);
compiler.plugin('done', () => done());
compiler.hooks.done.tap('AureliaCLI', done);
}
}

0 comments on commit 8b5d732

Please sign in to comment.